- Issue created by @catch
- Status changed to Needs review
4 months ago 2:43pm 11 August 2024 - 🇬🇧United Kingdom catch
1 CPU and this still finishes in under a minute. Needed to pull in 🐛 CoreRecipesTest is slow RTBC and 📌 Show test run time by class in run-tests.sh output Fixed to see what's going on, but other changes here should be ready for review.
- 🇬🇧United Kingdom catch
Added @group #slow to a handful of tests to maximize the concurrency towards the end of the test runs, and this one came out at 39 seconds https://git.drupalcode.org/project/drupal/-/jobs/2412264/viewer
Current test runs take over a minute, but this is because of 🐛 CoreRecipesTest is slow RTBC which is causing functional tests to be run in the phpunit test job. However can't really beat 39 seconds so shows going down to one CPU is fine.
There are unit tests reading files, sleep()ing etc. so the tests aren't entirely CPU constrainted.
- 🇬🇧United Kingdom catch
Reverted the changes that aren't specific to this issue.
- 🇬🇧United Kingdom catch
No the pipeline changes are the main thing in this issue. The @group #slow just ensures that with reduced concurrency we won't end up with long-running tests starting at the end of the run.
- Status changed to RTBC
4 months ago 1:25pm 12 August 2024 - 🇺🇸United States smustgrave
Ah gotcha, well based on your findings #5 say lets give it a shot
- Status changed to Downport
4 months ago 8:54am 13 August 2024 - Status changed to Needs work
4 months ago 9:20am 13 August 2024 - 🇫🇷France nod_ Lille
had to revert:
---- Drupal\Tests\PhpCs\SortTest ---- Status Group Filename Line Function -------------------------------------------------------------------------------- Fail Other phpunit-447.xml 0 Drupal\Tests\PhpCs\SortTest PHPUnit Test failed to complete; Error: PHPUnit 10.5.29 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.10 Configuration: /builds/project/drupal/core/phpunit.xml.dist .F 2 / 2 (100%) Time: 00:00.024, Memory: 8.00 MB There was 1 failure: 1) Drupal\Tests\PhpCs\SortTest::testSorted Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ 1 => '*/node_modules/*' 2 => './assets/vendor/*' 3 => './core/.phpstan-baseline.php' - 4 => './core/phpstan-tmp/*' - 5 => './core/lib/Drupal/Component/Diff/' + 4 => './core/lib/Drupal/Component/Diff/' + 5 => './core/phpstan-tmp/*' 6 => './core/tests/Drupal/Tests/Com...trine/' 7 => './modules/system/tests/fixtur...ssTest' ) /builds/project/drupal/core/tests/Drupal/Tests/PhpCs/SortTest.php:98 /builds/project/drupal/core/tests/Drupal/Tests/PhpCs/SortTest.php:56 FAILURES! Tests: 2, Assertions: 7, Failures: 1.
- Status changed to RTBC
4 months ago 9:46am 13 August 2024 - 🇬🇧United Kingdom catch
The commit here accidentally included 📌 Ignore phpstan-tmp in phpcs.xml.dist RTBC , hence the test failure since the MR over there had the same one. Moving back to RTBC.
- Status changed to Downport
4 months ago 9:58am 13 August 2024 - Status changed to Fixed
4 months ago 10:17am 13 August 2024 - 🇫🇷France nod_ Lille
Automatically closed - issue fixed for 2 weeks with no activity.