- Issue created by @longwave
- π¬π§United Kingdom longwave UK
Oh, we can't remove it, because we did this so GitLab CI can access the cache as an artifact. So let's just ignore it for phpcs.
- Status changed to Needs review
4 months ago 5:40pm 7 August 2024 - Status changed to RTBC
3 months ago 12:45pm 12 August 2024 - πΊπΈUnited States smustgrave
Seems pretty straight forward. Can't re-run failing unit tests but highly doubt this change broke those.
- Status changed to Needs review
3 months ago 10:38pm 12 August 2024 - π«π·France nod_ Lille
we're also creating:
core/.cspellcache core/.eslintcache core/.stylelintcache
Should they be excluded as well or doesn't matter since they don't have php inthem?
- Status changed to Needs work
3 months ago 10:39pm 12 August 2024 - π«π·France nod_ Lille
test failure is legit
Status Group Filename Line Function -------------------------------------------------------------------------------- Fail Other phpunit-440.xml 0 Drupal\Tests\PhpCs\SortTest PHPUnit Test failed to complete; Error: PHPUnit 10.5.29 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.10 Configuration: /builds/project/drupal/core/phpunit.xml.dist .F 2 / 2 (100%) Time: 00:00.025, Memory: 8.00 MB There was 1 failure: 1) Drupal\Tests\PhpCs\SortTest::testSorted Failed asserting that two arrays are equal. --- Expected +++ Actual @@ @@ 1 => '*/node_modules/*' 2 => './assets/vendor/*' 3 => './core/.phpstan-baseline.php' - 4 => './core/phpstan-tmp/*' - 5 => './core/lib/Drupal/Component/Diff/' + 4 => './core/lib/Drupal/Component/Diff/' + 5 => './core/phpstan-tmp/*' 6 => './core/tests/Drupal/Tests/Com...trine/' 7 => './modules/system/tests/fixtur...ssTest' ) /builds/project/drupal/core/tests/Drupal/Tests/PhpCs/SortTest.php:98 /builds/project/drupal/core/tests/Drupal/Tests/PhpCs/SortTest.php:56 FAILURES! Tests: 2, Assertions: 7, Failures: 1.
- First commit to issue fork.
- Status changed to RTBC
3 months ago 9:44am 13 August 2024 - π¬π§United Kingdom catch
I think #7 doesn't matter - we can always add those in a follow-up.
Fixed the test - PHP orders differently from humans.
- Status changed to Fixed
3 months ago 10:05am 13 August 2024 - π«π·France nod_ Lille
Committed and pushed 576253ca19 to 11.x and 63980670bb to 11.0.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.