- Issue created by @phenaproxima
- ๐ฎ๐ณIndia yash.rode pune
yash.rode โ made their first commit to this issueโs fork.
- Assigned to yash.rode
- Issue was unassigned.
- Status changed to Needs review
8 months ago 1:03pm 9 August 2024 - ๐ฎ๐ณIndia prashant.c Dharamshala
@yash.rode
Great work.Tried the element on a Custom Form
$form['pb'] = [ '#type' => 'project_browser', ];
and it worked well.
But I see there is another property
#source
I am assuming this is to restrict the list to the supplied source only likedrupal_core
ordrupalorg_jsonapi
source etc. I tried this property but nothing happening. Both sources are already enabled.Could you please provide some details on how to use these properties
#source
and#id
?Thanks
- ๐ฎ๐ณIndia yash.rode pune
Hi @Prashant.c as you can see the path
/admin/modules/browse/{source}/{id}'
when viewing the/admin/modules/browse
page both $source and $id are null and for a details page likehttp://starshot.test/admin/modules/browse/recipes/drupal-core-core_recommended_admin_theme
wheresource
isrecipes
andid
isdrupal-core-core_recommended_admin_theme
. In that case one can use the#source
and#id
to see the detail page of specific recipes/module. - Status changed to Needs work
8 months ago 12:16pm 12 August 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
Pretty close, just a few more points.
- ๐ฎ๐ณIndia prashant.c Dharamshala
#7 ๐ Expose the project browser as a render element Needs work , thanks for the clarifications, as mentioned by @phenaproxima having the properties documented in the the doc comments would be helpful.
- Status changed to RTBC
8 months ago 2:31pm 16 August 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
@yash.rode pointed me to a very tricky bug, and I found the root cause -- but credit where credit is due, I wouldn't have been able to trace it if @yash.rode hadn't expertly isolated the problem. That's fixed now.
Other than that, I think this MR looks great. Ship it!
- Status changed to Needs work
8 months ago 2:33pm 16 August 2024 - ๐บ๐ธUnited States phenaproxima Massachusetts
Ugh, guess we need a little more work to get the tests passing. Poop.
- Status changed to RTBC
8 months ago 2:56pm 16 August 2024 - ๐ฎ๐ณIndia yash.rode pune
The test failure is because of ๐ Remove Modals after They're Closed Fixed which is merged in upstream.
- ๐ฎ๐ณIndia prashant.c Dharamshala
It looks like this test failing
https://git.drupalcode.org/project/project_browser/-/blob/2.0.x/tests/src/FunctionalJavascript/ProjectBrowserUiTest.php?ref_type=heads
- First commit to issue fork.
-
chrisfromredfin โ
committed 02975bd7 on 2.0.x authored by
yash.rode โ
Issue #3466307 by yash.rode, phenaproxima, chrisfromredfin, prashant.c:...
-
chrisfromredfin โ
committed 02975bd7 on 2.0.x authored by
yash.rode โ
- Status changed to Fixed
8 months ago 4:17pm 21 August 2024 - ๐บ๐ธUnited States chrisfromredfin Portland, Maine
Excellent behind-the-scenes work
Automatically closed - issue fixed for 2 weeks with no activity.