Olivero pager template creates additional grid columns

Open on Drupal.org →

Created on 5 August 2024, 5 months ago

Problem/Motivation

Olivero's templates/navigation/pager.html.twig nav element has the layout--content-medium class, whose CSS rules apply grid-column at various breakpoints, thus creating additional columns. E.g. grid-column: 1 / 11;, creating 10 additional columns in the parent container. This issue is also present in Drupal 10.x-dev.

Proposed resolution

Remove the layout--content-medium class from the pager's nav element.

Remaining tasks

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Last updated 3 days ago

Maintained by
🇺🇸United States @mherchel
🇺🇸United States @proeung
🇺🇸United States @jwitkowski79
🇷🇺Russia @kostyashupenko
🇺🇸United States @andy-blum

Created by

🇺🇸United States FrankieD3

Live updates comments and jobs are added and updated live.

Needs subsystem maintainer review
It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Sign in to follow issues

Merge Requests

!9086Olivero pager template creates additional grid columns
Open
🇺🇸United States FrankieD3
updated 5 months ago

Comments & Activities

Issue created by @FrankieD3
Assigned to FrankieD3
Comment 5 months ago →
🇺🇸United States FrankieD3
Merge request !9086Removed the "layout--content-medium" class from the nav element in Olivero's pager template. → (Open) created by FrankieD3
Comment 5 months ago →
🇺🇸United States FrankieD3
Status changed to Needs review 5 months ago3:48pm 5 August 2024
Comment 5 months ago →
🇺🇸United States FrankieD3
Status changed to Needs work 5 months ago4:08pm 5 August 2024
Comment 5 months ago →
🇺🇸United States smustgrave
There's a number of CSS attached to this class. Don't think it can just be removed
Comment 5 months ago →
🇺🇸United States FrankieD3
It looks to me that the pager does not benefit from any of the class's properties and can safely be removed from the element. All it inherits from the layout--content-medium class is a width of 100%, as well as statically set grid-column values per breakpoint.
It's very possible that I've missed something, though. If I have, please let me know!
Comment 5 months ago →
🇺🇸United States smustgrave
Pipeline finished with Success
5 months ago
Total: 8980s
#244670

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024