- Issue created by @FrankieD3
- Assigned to FrankieD3
- Merge request !9086Removed the "layout--content-medium" class from the nav element in Olivero's pager template. → (Closed) created by FrankieD3
- Status changed to Needs review
9 months ago 3:48pm 5 August 2024 - Status changed to Needs work
9 months ago 4:08pm 5 August 2024 - 🇺🇸United States smustgrave
There's a number of CSS attached to this class. Don't think it can just be removed
- 🇺🇸United States FrankieD3
It looks to me that the pager does not benefit from any of the class's properties and can safely be removed from the element. All it inherits from the
layout--content-mediumclass is a width of 100%, as well as statically set grid-column values per breakpoint.
It's very possible that I've missed something, though. If I have, please let me know! - Status changed to Needs review
4 months ago 8:29pm 26 January 2025 - 🇳🇱Netherlands johnv
The following issues are duplicates, having competing solution proposals:
🐛 Views incorrect display with filters, table and full pager Active adds 'margin-block-end'
🐛 Olivero pager template creates additional grid columns Needs work removes 'layout--content-medium'
🐛 Using 'Paged output, full pager' changes view table display Active (without patch, but contains nice screenprints in #3 and #5)
I cannot judge which solution proposal is best. I guess the second one.I guess the 'Needs subsystem maintainer review' allows the patch to be reset to 'Needs review'.
- 🇺🇸United States FrankieD3
I'm not privy to test writing, so if anyone would like to pick this up, be my guest!
- Issue was unassigned.
- Status changed to RTBC
about 1 month ago 8:12am 31 March 2025 - 🇬🇧United Kingdom catch
There's no way to test this, it's a visual issue and we don't have visual regression testing for core.
What this does need though is before/after screenshots with/without the fix following the steps to reproduce in the issue summary.
This looks like the right fix to me, so marking 🐛 Views incorrect display with filters, table and full pager Active as duplicate.
- 🇬🇧United Kingdom catch
Wrong status, but I think it probably is RTBC once there's screenshots.
- 🇳🇱Netherlands johnv
Please find screenshots attached for admin/content view: pre and post Olivero, and for comparison also a Claro screenshot.
I have assured that this view has a full pager.Please also take a look at the duplicate issues from #9
- 🇬🇧United Kingdom catch
Going to go ahead here since the actual solution is trivial despite the 'needs subsystem maintainer' tag. If we'd gone for one of the more complex solutions explored then I would have held off a bit more. Committed/pushed to 11.x and 10.5.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.