'field_group_accordion' is missing its dependency module jquery_ui_accordion

Created on 4 August 2024, about 2 months ago
Updated 9 September 2024, 9 days ago

Problem/Motivation

I don't use the field group accordion, Field Group: Accordion formatter is also deprecated but the problem persists when upgrading to 8.3.6.I can't update the site after upgrading the FG module to 8.3.6

πŸ› Bug report
Status

Closed: won't fix

Version

3.0

Component

Miscellaneous

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @pearls
  • Install that module and then run update again.

    composer require "drupal/jquery_ui_accordion:^2.1"

    I would suggest searching exported config for format_type: accordion afterwards to see where accordion is used, change it and then get rid of jquery_ui_accordion module for good.

  • πŸ‡ΊπŸ‡ΈUnited States shelane

    For the same effect (make a group of fields collapsible), use "Detail" for the field group type.

  • πŸ‡―πŸ‡΅Japan s-jack Tokyo

    I have encountered a similar case.
    This is on a site installed from Drupal 10.
    I am not using the accordion type.

    Why do I have to install jquery_ui_accordion once?

    In an era where we are updating towards Drupal 11 without using Composer manually, having to do this manually would be a huge hindrance.

    I also don't know how to find the format_type: accordion configuration, as I am not a developer.

    Thanks for the field group module.

  • πŸ‡«πŸ‡·France Nicolas Bouteille

    We're pretty sure we don't use accordion either with field_group.
    We too don't feel happy about having to require jquery_ui_accordion in our composer.json.
    Any chance update_8303 does not correctly checks whether accordion type is used?
    Staying on 3.4.0 until you guys can sort this out.

  • πŸ‡«πŸ‡·France Nicolas Bouteille

    I just read in 3.5 release notes that "Accordion is now a separate deprecated module to notify people that this shouldn't be used anymore" so definitely don't feel like adding jquery_ui_accordion in composer if not using it...

  • πŸ‡«πŸ‡·France dxx

    The field_group module only require the field_group_accordion if you use the accordion or accordion_item anywhere in your configuration.

    Since your are updated your configuration (display views) to remove any usage of format_type: accordion or format_type: accordion_item, you can safety do the following to remove this deprecated modules (if you no longer use `jquery_ui`):

    drush pmu jquery_ui
    drush pmu jquery_ui_accordion
    composer remove drupal/jquery_ui_accordion drupal/jquery_ui
    
  • πŸ‡«πŸ‡·France Nicolas Bouteille

    Ok thanks for the help, indeed, looking for accordion in the config helped us find out where we actually used it!
    All good then now we can decide what we do!

  • πŸ‡ΊπŸ‡ΈUnited States joegl

    If an update hook is going to install a module, the module should probably be included as a composer dependency. A failed update (even due to a deprecation) isn't the way.

    Also, if there is a a deprecation, it'd be great to have the notice and steps to upgrade in the release notes for the release.

  • πŸ‡³πŸ‡±Netherlands Jan-E

    The deprecation notice is quite unclear:

    jQuery UI Accordion is deprecated
    This module is deprecated, as the Jquery UI library is EOL.

    Exactly what of the Jquery UI library is EOL? 15 days ago there was a new release (1.14.0):
    https://blog.jqueryui.com/category/releases/

  • πŸ‡―πŸ‡΅Japan s-jack Tokyo

    The jquery_ui module and several related modules are used, such as better_exposed_filters and the taxonomy_manager module.

  • πŸ‡³πŸ‡±Netherlands Jan-E

    I have got the jquery_ui module installed and it does not issue a deprecation warning. That is why I went directly to the Jquery UI library it self to see if the upstream was deprecated. And saw that it was actively (though minimally) maintained. The deprecation message for the field_group submodule made no sense to me, because the jquery_ui module has changed into 'composer require and forget'.
    The 'End-user experience' in https://www.drupal.org/project/jquery_ui/issues/3277748 ✨ Drupal 10 compatibility Fixed is exactly what happened to me. Notice that at the moment even 201,719 sites have the Jquery UI module 8.x-1.x installed. The usage of that module has grown significantly since it became deprecated without telling the end-user.
    https://www.drupal.org/project/usage/jquery_ui β†’ does not look at all like a deprecated module.

  • πŸ‡―πŸ‡΅Japan s-jack Tokyo

    This may be an off-topic question, but I'm sorry.

    I followed the advice.
    composer require "drupal/jquery_ui_accordion:^2.1"

    I have not installed the jquery_ui_accordion module by UI or Drush.
    I just imported it with Composer.
    As a test, I tried updating the database without installing it.
    The database update that was causing the problem was successful.

    I have a question, but will the module be automatically installed when I update the database?

  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    So I guess this can be closed won't fix?

  • Status changed to Closed: won't fix 9 days ago
  • πŸ‡©πŸ‡ͺGermany Anybody Porta Westfalica

    Just verified the requirement is present in the .info.yml: https://git.drupalcode.org/issue/field_group-3465794/-/blob/3465794-fiel...

    We can't add it to the composer.json as it's not possible for submodules.

    What could have been done is writing an update hook or a hook_requirements to check this, but as the submodule is deprecated anyway I think we should close this won't fix.

    If anyone disagrees, feel free to reopen and implement it. Thanks!

Production build 0.71.5 2024