- Issue created by @thejimbirch
- Status changed to Postponed
3 months ago 1:47am 17 August 2024 - πΊπΈUnited States smustgrave
Sent a slack message to the maintainer to make sure it's fine we merge their code.
Also would like to get β¨ Improve the structure and organization of the tours list page Active before as they may overlap some.
- Status changed to Active
3 months ago 2:22pm 30 August 2024 - πΊπΈUnited States smustgrave
Bumping again for β¨ Tour and No Tour available button labels should not be required Active
Haven't been able to get a hold of maintainer of Tour builder module either.
- Merge request !79Issue #3465646: Merge in functionality from the Tour Builder module β (Merged) created by smustgrave
- π³π±Netherlands clemens.tolboom Groningen, π³π±/πͺπΊ
smustgrave β credited clemens.tolboom β .
- πΊπΈUnited States smustgrave
So I brought over the configuration export and clone feature. Left the export out as it seems very similar to the export config feature.
Added some test coverage as well.
- π©πͺGermany rkoller NΓΌrnberg, Germany
I've noticed a few details testing MR79. When you are cloning a tour the field label is sort of lengthy. Would it make sense to shorten
File name for new tour item.
to justFile name
(it is odd anyway having a full sentence case here as a label). the detail about the new tour item might be added to the description if necessary. The more serious problem probably is that you are able to use spaces in the file name, and doing so leads to a machine name with spaces as well, and it is also possible to use upper cases? as far as i know all that is not permitted for drupal? would it make sense to add a validation to the form as well as a note about these constraints, if i am not mistaken about that, to the description? - π©πͺGermany rkoller NΓΌrnberg, Germany
what would have been the output for the export? (on a sidenote
export (configuration)
makes the button quite wide. -
smustgrave β
committed c0a373c9 on 2.0.x
Issue #3465646: Merge in functionality from the Tour Builder module
-
smustgrave β
committed c0a373c9 on 2.0.x
-
smustgrave β
committed 7f8a9e90 on 2.0.x
Issue #3465646 by smustgrave, rkoller, thejimbirch, clemens.tolboom:...
-
smustgrave β
committed 7f8a9e90 on 2.0.x
- πΊπΈUnited States smustgrave
The export was virtually the same minus uuid keys
- π©πͺGermany rkoller NΓΌrnberg, Germany
oh ok thanks! but what is with the points in #10?
- π³π±Netherlands clemens.tolboom Groningen, π³π±/πͺπΊ
Nice to merge from Tour Builder :-)
@smustgrave I never got a Slack message (as I do not use it) and am inactive regarding Drupal
- πΊπΈUnited States smustgrave
No worries! Functionality was a welcomed addition for the second iteration of tour
Automatically closed - issue fixed for 2 weeks with no activity.