- Issue created by @Wim Leers
- First commit to issue fork.
- Merge request !133Changed the color for text as we are using white background → (Merged) created by Utkarsh_33
- Status changed to Needs review
about 2 months ago 9:50am 1 August 2024 - Assigned to bnjmnm
- Status changed to RTBC
about 2 months ago 9:52am 1 August 2024 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Thanks, @Utkarsh_33!
So, turns out that the labels were visible, they just had no contrast at all 😅🤣
AFAICT that means that the
to.be.visibleassertion you added would have passed already anyway; in theory we should test that the contrast is sufficient, but that seems unnecessarily detailed.I think this is fine as-is, but deferring to @bnjmnm, our accessibility expert, and also the primary author of this functionality 😊
- Issue was unassigned.
- Status changed to Needs work
about 2 months ago 10:49am 1 August 2024 - Status changed to Needs review
about 2 months ago 11:51am 1 August 2024 -
bnjmnm →
committed c8eb44a3 on 0.x authored by
Utkarsh_33 →
Issue #3465140 by Utkarsh_33, bnjmnm, Wim Leers: Regression: prop labels...
-
bnjmnm →
committed c8eb44a3 on 0.x authored by
Utkarsh_33 →
- Status changed to Fixed
about 2 months ago 1:02pm 1 August 2024 - 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Nice, a bug fixed by only deleting code 😁
Automatically closed - issue fixed for 2 weeks with no activity.
