Contrib.social

[PP-1] \Drupal\experience_builder\Plugin\DataType\ComponentTreeHydrated::getValue should not return a response object

Open on Drupal.org →
Created on 1 August 2024, 4 months ago
Updated 9 August 2024, 4 months ago

Overview

\Drupal\experience_builder\Plugin\DataType\ComponentTreeHydrated::getValue returns a CacheableJsonResponse which takes a data structure and then converts it into a string, but then in \Drupal\experience_builder\Controller\SdcController::layout we take the string, json_decode and work with it again.

Proposed resolution

Wait for 📌 Add typed value-objects for the component tree structure Needs review and then stop casting to and from strings

User interface changes

📌 Task
Status

Postponed

Component

Data model

Created by

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024