Create a value object for the return of ComponentTreeHydrated::getValue

Open on Drupal.org →

Created on 16 December 2024, 3 days ago

Overview

A lot of code is calling ::getValue on \Drupal\experience_builder\Plugin\DataType\ComponentTreeHydrated and then calling json_decode on the content.
In some cases we call this multiple times (see buildLayout in ApiLayoutController)

Proposed resolution

Introduce a value object that keeps the unencoded hydrated tree and cacheability metadata. Access the unencoded values instead of calling json_decode so much

User interface changes

📌 Task

Status

Active

Version

0.0

Component

Data model

Created by

🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!477Create a value object for the return of ComponentTreeHydrated::getValue
Merged
🇦🇺Australia larowlan
updated 2 days ago

Comments & Activities

Issue created by @larowlan
Merge request !477Add value object → (Merged) created by larowlan
Comment 3 days ago →
🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Comment 2 days ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 2 days ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 2 days ago →
System Message

wim leers → committed 8f558dde on 0.x authored by larowlan →
Issue #3494331 by wim leers, larowlan: Create a value object for the...
Comment 2 days ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Comment 2 days ago →
🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@larowlan previously opened an issue for this: 🐛 \Drupal\experience_builder\Plugin\DataType\ComponentTreeHydrated::getValue should not return a response object Active — this was effectively a newer duplicate 😊

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024