FormState::getTriggeringElement() behaves inconsistently when request is malformed

Not sure why but it seems I can't create a merge request here : https://git.drupalcode.org/issue/drupal-3465041/-/compare/10.3.x...34650...

Opened MR for ya but I think the branch was opened against 10.3 vs 11.x as there are a lot of changes.

I rebased against 11.x.

Thanks!

Appears to have a test failure so without digging into the test may need to consider that scenario to make sure we aren't breaking existing stuff. That said probably would need a test case or additional assertion somewhere.

I added a test.

Failing tests seem to be unrelated, they were passing previously and I did not change the code since: https://git.drupalcode.org/issue/drupal-3465041/-/pipelines/265276
It seems the tests are unusually slow and it causes some timeouts?

I noticed the fork branch was quite old so I merged the latest 11.x and now tests are passing.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed the comment format but rest seems to be addressed