- Issue created by @prudloff
- Status changed to Needs review
7 months ago 10:23am 26 August 2024 - 🇫🇷France prudloff Lille
Not sure why but it seems I can't create a merge request here : https://git.drupalcode.org/issue/drupal-3465041/-/compare/10.3.x...34650...
- Merge request !9328Issue #3454196 by james.williams, longwave: Filter placeholders without... → (Open) created by smustgrave
- Status changed to Needs work
7 months ago 1:34pm 26 August 2024 - 🇺🇸United States smustgrave
Opened MR for ya but I think the branch was opened against 10.3 vs 11.x as there are a lot of changes.
- Status changed to Needs review
7 months ago 6:02pm 26 August 2024 - Status changed to Needs work
7 months ago 12:22pm 27 August 2024 - 🇺🇸United States smustgrave
Thanks!
Appears to have a test failure so without digging into the test may need to consider that scenario to make sure we aren't breaking existing stuff. That said probably would need a test case or additional assertion somewhere.
- Status changed to Needs review
9 days ago 8:29pm 5 March 2025 - 🇫🇷France prudloff Lille
I added a test.
Failing tests seem to be unrelated, they were passing previously and I did not change the code since: https://git.drupalcode.org/issue/drupal-3465041/-/pipelines/265276
It seems the tests are unusually slow and it causes some timeouts? - 🇫🇷France prudloff Lille
I noticed the fork branch was quite old so I merged the latest 11.x and now tests are passing.