On /admin/structure/flags/add/entity%3Anode I get this message:
Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in message_subscribe_ui_form_flag_form_alter() (line 19 of modules/contrib/message_subscribe/message_subscribe_ui/message_subscribe_ui.module).
Looking into the code:
function message_subscribe_ui_form_flag_form_alter(array &$form, FormStateInterface $form_state, $form_id) {
$prefix = \Drupal::config('message_subscribe.settings')->get('flag_prefix');
/** @var \Drupal\flag\FlagInterface $flag */
$flag = $form_state->getFormObject()->getEntity();
if (strpos($flag->id(), $prefix) === 0) {
If this is a flag create form, the $flag->id() will be null, but strpos() expects a string.
PHP 8.1+
message_subscribe 8.x-1.3
Errors displayed to the screen.
Visit /admin/structure/flags/add/entity%3Anode.
Or /admin/structure/flags/add/entity:node
Expected: No error.
Actual: Error as above.
We need a well-defined behavior in case the $flag->id() is null.
Currently this would be cast to empty string, so strpos('', $prefix) === 0 will fail, unless $prefix is also empty.
Needs review
1.3
Code
Hi @donquixote,
I have resolved this issue with passing null to strpos and created MR!23.
Kindly review and verify.
I don't know if it fixed the entire problem, but after the patch the warning disappeared.
+1 RTBC for MR23 for now.