- Issue created by @catch
- First commit to issue fork.
- Status changed to Needs review
3 months ago 10:54pm 24 July 2024 - Status changed to Needs work
3 months ago 4:50pm 25 July 2024 - πΊπΈUnited States smustgrave
So ran the test locally without the change to system.install and the test still passes. Shouldn't it fail?
- Status changed to Needs review
3 months ago 4:08am 26 July 2024 - π³πΏNew Zealand quietone
No it should not fail, it is independent of the system.install. The test is relying on the downgrade_test module to provide the hook and that module is only installed in the test after proving the requirement failure. The test is a functional test of the concept. There is no similar test using the actual system_update_11101 because I don't see a way to prevent the update process from finding and executing that hook.
- Status changed to Needs work
3 months ago 8:57pm 30 July 2024 - πΊπΈUnited States xjm
I left some comments on the test. It could use some clarification since update tests are dark magic.
I think we need also need the MR that adds the equivalent system update to review this properly, no?
- Status changed to Needs review
3 months ago 1:56am 31 July 2024 - Status changed to Needs work
3 months ago 5:42pm 1 August 2024