Use the new equivalent updates API to prevent updates from 10.4.0 to 11.0.0

So ran the test locally without the change to system.install and the test still passes. Shouldn't it fail?

No it should not fail, it is independent of the system.install. The test is relying on the downgrade_test module to provide the hook and that module is only installed in the test after proving the requirement failure. The test is a functional test of the concept. There is no similar test using the actual system_update_11101 because I don't see a way to prevent the update process from finding and executing that hook.

I left some comments on the test. It could use some clarification since update tests are dark magic.

I think we need also need the MR that adds the equivalent system update to review this properly, no?

Still NW for a second MR for 10.4, I think.

Made some minor improvements and the 10.4.x MR as well.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Two minor nits on the MR but otherwise RTBC for me. Would be good to get this in before the 10.4 beta, although I also think it could go in during the beta if necessary.

Working on @catch's concerns for the 10.4 MR

Fixed the nits in the 10.4.x MR, then cherry-picked those commits into the 11.x MR. Also did some more cleanup in the 11.x MR. I think this is ready for re-review.

FYI, I opened 📌 [PP-1] Move all system_update_N() methods next to each other Postponed to cleanup a weirdness once this issue is committed to 11.x and 11.1.x.

I converted the version numbers to be specific for 10.4 and 11.

Saving credits. So far, everyone has meaningfully contributed here.

Both MRs lgtm.

Committed/pushed the two MRs to 11.x/11.1.x and 10.5.x/10.4.x respectively. Thanks!

We'll need to decide if we do a similar thing for 10.5.x->11.1.x too.

catch → closed merge request !10038

catch → closed merge request !8900

Automatically closed - issue fixed for 2 weeks with no activity.

Should the 10.4, 11.0 and 11.1 release notes be updated to more clearly state this requirement in the upgrade process? While people will run into the issue if they try upgrading from 10.4 to 11.0, the issue is obscured and many are not aware of it.