Mentioning nodes doesn't set href

Created on 20 July 2024, about 2 months ago
Updated 6 September 2024, 1 day ago

Problem/Motivation

Hi, the base implementation of MentionsTypeBase does not generate URLs for entities, and since the node plugin only overrides the getQuery method, the referenced nodes do not have an href.

In mentioning users, this works because the user plugin overrides the buildTokens method and adds the URL.

Steps to reproduce

Mention the node and check the added markup.

Proposed resolution

Add URL generation to the MentionsTypeBase::buildTokens() method.

Remaining tasks

  1. Fix.
  2. Test coverage.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report
Status

RTBC

Version

3.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024