Contrib.social

Stop using a data provider in UserPasswordResetTest

Open on Drupal.org →
Created on 19 July 2024, about 2 months ago
Updated 12 August 2024, 26 days ago

Problem/Motivation

UserPasswordResetTest uses a data provider, which because it's a functional test, means it installs Drupal twice more than it needs to. We can just use a foreach instead.

Before:

 ../vendor/bin/phpunit modules/user/tests/src/Functional/UserPasswordResetTest.php 
PHPUnit 10.5.26 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.8
Configuration: /var/www/html/core/phpunit.xml

	............                                                      12 / 12 (100%)

Time: 00:34.405, Memory: 6.00 MB

After:

 ../vendor/bin/phpunit modules/user/tests/src/Functional/UserPasswordResetTest.php 
PHPUnit 10.5.26 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.8
Configuration: /var/www/html/core/phpunit.xml

..........                                                        10 / 10 (100%)

Time: 00:28.516, Memory: 6.00 MB

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.3 ✨

Component
User module  →

Last updated 1 day ago

Created by

🇬🇧United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024