- Issue created by @prashant.c
- First commit to issue fork.
- Merge request !89Issue #3462559: Moved link 'Custom block library' to 'Blocks' under the... → (Merged) created by dydave
- Status changed to Needs review
4 months ago 12:28am 24 July 2024 - 🇫🇷France dydave
This change seems to have been introduced in 10.1.0, see issue ✨ Move Custom block library to Content Fixed with change record: Block management pages have new paths and menu items → .
At this point, merge request MR!89 doesn't take into account backward compatibility (pre-10.1.0).
If BC for versions < 10.1.0 is required, we could always keep the existing code wrapped in a statement
if (version_compare(\Drupal::VERSION, '10.1', '<')) {
and the code from the MR for versions >= 10.1.0.Tests have been run locally and they would seem to still pass ✅
(with a few other patches 📌 GitlabCI support: Add config file and fix PHPUnit tests RTBC )Based on how the maintainers would like to approach this issue: remaining to be addressed backward compatibility and/or adding test case.
We would greatly appreciate to have your feedback and reviews on the suggested changes.
Thanks in advance! - First commit to issue fork.
- Status changed to Needs work
4 months ago 4:28pm 2 August 2024 - 🇺🇸United States japerry KVUO
For the most part, the code works in Drupal 9. The main thing missing is the link to the block type definition page, which should be easy to shim in.
- Status changed to Needs review
4 months ago 6:50pm 2 August 2024 - 🇫🇷France dydave
Thanks a lot Jakob (@japerry) for the great help on this issue and the project in general!
The changes you've suggested above at #6 have been updated in MR!89 and are ready to be reviewed:
The existing code for the
Block types
link was kept and wrapped in a version comparison statement, which should leave this link's behavior untouched for versions below 10.1.✅ Tests still seem to be passing:
MR: https://git.drupalcode.org/issue/admin_toolbar-3462559/-/pipelines/242038
Thanks in advance for your testing, reviews and feedback!
- Status changed to Fixed
4 months ago 7:04pm 2 August 2024 - 🇺🇸United States japerry KVUO
Perfect, looks good in D9, 10, and 11. Committed.
Automatically closed - issue fixed for 2 weeks with no activity.