- Issue created by @larowlan
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Yes, please!
\Drupal\experience_builder\Controller\SdcController::layout()
has this horribleness:public function layout(): JsonResponse { $first_article = Node::load(1); if (!$first_article || $first_article->getType() !== 'article') { throw new \LogicException('For now, this assumes node 1 exists and is an article!'); } assert($first_article->field_xb_demo[0] instanceof ComponentTreeItem); $tree = $first_article->field_xb_demo[0]->get('tree'); assert($tree instanceof ComponentTreeStructure); $hydrated = $first_article->field_xb_demo[0]->get('hydrated'); assert($hydrated instanceof ComponentTreeHydrated); $hydrated_json = $hydrated->getValue()->getContent();
That's something that this should remove π€
(Thanks for creating this issue!)
I'm running into this too over at π Evolve component instance edit form to become simpler: generate a Field Widget directly Fixed .
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Ensuring this shows up on https://contribkanban.com/board/experience_builder.
- Status changed to Needs review
about 1 month ago 3:58am 1 August 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
Are these commit messages auto-generated and random? π€ͺπ€£
- Status changed to Postponed
about 1 month ago 5:21am 1 August 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
The MR indicates that this depends on π Clarify if local dev on /ui should be possible without Drupal Needs review , reflecting that.
- Status changed to Needs work
about 1 month ago 5:30am 1 August 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
π Clarify if local dev on /ui should be possible without Drupal Needs review should land first, but that didn't stop me from reviewing π
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Are these commit messages auto-generated and random?
Na, I'm just having fun with portlandia quotes
- Assigned to bnjmnm
- Status changed to Needs review
about 1 month ago 3:05pm 1 August 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
The back-end changes here (in the controllers +
*.routing.yml
) make sense.The front-end changes I'd like to be reviewed by either @bnjmnm or @jessebaker π
- First commit to issue fork.
- Issue was unassigned.
- Status changed to RTBC
about 1 month ago 3:03pm 2 August 2024 -
Wim Leers β
committed b404bbf2 on 0.x authored by
larowlan β
Issue #3462247 by larowlan, bnjmnm, Wim Leers: Start passing entity type...
-
Wim Leers β
committed b404bbf2 on 0.x authored by
larowlan β
- Status changed to Fixed
about 1 month ago 3:10pm 2 August 2024 - π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
This caused a small regression, which π Introduce `hook_storable_prop_shape_alter()`, use it to prefer the Media Library widget for "image" PropShape if Media Library is installed Fixed surfaced. Fixed by removing one character in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
- π§πͺBelgium Wim Leers Ghent π§πͺπͺπΊ
This introduced a regression: π Regression caused by #3462247: `configure` route in *.info.yml needs params Active .
Automatically closed - issue fixed for 2 weeks with no activity.