Introduce `hook_storable_prop_shape_alter()`, use it to prefer the Media Library widget for "image" PropShape if Media Library is installed

"could", but why? There seems to be plenty of issues with front-end work to be done?

I filed this issue during our weekly planning with you, based on instructions I received from you. 🤔 I agree that the issue summary could use some more context but I don't have any more information than you to expand on this.

Yes, I said we could do that if needed. It'd unblock front-end discovery work on 📌 Media Library integration (includes introducing a new main content renderer/`_wrapper_format`) Fixed if there were not enough actionable work in 🌱 [META] Early phase front-end work coordination Active . But there's ~half a dozen of critical issues ready to be worked on there.

I'll self-assign to revisit this during this sprint if those half dozen front-end issues have landed. But I'd prefer to not do this, and instead just do 📌 Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings Fixed . But we first need to get on the same page on that.

Discussed with @lauriii. Now that 📌 Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings Fixed is virtually done, it makes sense to keep this blocked on 📌 Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings Fixed .

📌 Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings Fixed is in.

Still cleaning this up (hacked my way to success!), but I've gotten to the point where the \Drupal\media_library\Plugin\Field\FieldWidget\MediaLibraryWidget does load 😊

This will 100% need a dependency on the media module since we're assuming it is there, and even though it's not necessary to function the media library module should probably also be there since that's the widget we indend to use.

💯

I just introduced hook_storage_prop_shape_alter() + docs + infra — that fixes a @todo and minimizes the hardcoded nature.

It is also an essential step towards contrib extensibility/overridability, which we already knew in 📌 Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings Fixed that we'd have to add.

Retitling accordingly.

Review suggestion: see the section in the issue summary for the big picture. That should help you review this.

Alternatively: the commit history walks you through it via the commit messages.

🤣🙈

This conflicted with 📌 Start passing entity type/entity ID context to SdcController from the FE Fixed on the back-end side, and then tests failed here, due to a regression on the front-end side introduced by that same issue/MR: #3462247-17: Start passing entity type/entity ID context to SdcController from the FE → . Trivial fix though :)

This looks good. I made 2 very minor changes

@bnjmnm in #9: I know I agreed with you in #10, and then I didn't do it!

The reason is simple though: media_library_storage_prop_shape_alter() literally only is executed if the Media Library module is installed — even though that hook is implemented in experience_builder.module. It's simply implemented by XB on behalf of Media Library. It's a technique we've often used in experimental modules in Drupal core :) Hence also the without/with screenshots in the issue summary!

And as a bonus: that alter hook implementation checks even something more granular, to be on the safe side:

    // @todo Allow configuring which media type, for now this assumes the
    //   Standard 'image' media type.
    // @see core/profiles/standard/config/optional/media.type.image.yml
    if (!MediaType::load('image')) {
      return;
    }

Automatically closed - issue fixed for 2 weeks with no activity.