Contrib.social

Add tests for updates should not recommend a new branch if there are no stable releases

Open on Drupal.org →
Created on 16 July 2024, about 2 months ago
Updated 31 August 2024, 8 days ago

Problem/Motivation

I'm working on a stale 9.5.11 site that needs an core update. There's logic in update.module to not recommend releases with "extra" in their version string (alpha/beta/rc). However, right now, the 9.5.11 site is recommending 11.0.0-rc1 as the update target.

Steps to reproduce

  1. Install an older, unsupported branch of core. At the time of writing, 9.5.11.
  2. Make sure that the latest branch of core is marked as "Supported" on the d.o project node, but there's no official / stable release yet.
  3. Visit the available updates report at /admin/reports/updates
  4. Notice "Recommended version: 11.0.0-rc1 (2024-Jul-11)"

Proposed resolution

Fix the logic that's picking the "target major" for the available updates report to ignore so-called "supported" branches that don't actually have any stable releases yet.

Remaining tasks

  1. Add / update tests to show the bug.
  2. Fix the logic in update_calculate_project_update_status(), near this comment:
        // We know the current release is unsupported since it is not in
    // 'supported_branches' list. We should use the next valid supported
    // branch for the target major version.

User interface changes

Better recommendation when a new core branch is marked "supported" but has no stable releases.

Before

API changes

None.

Data model changes

None.

Release notes snippet

TBD.

🐛 Bug report
Status

Fixed

Version

10.3 ✨

Component
Update  →

Last updated 2 days ago

  • Maintained by
  • 🇺🇸United States @tedbow
  • 🇺🇸United States @dww
Created by

🇺🇸United States dww

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dww
  • Comment about 2 months ago →
    🇺🇸United States dww

    Adding screenshot from my local 9.5.11 site showing the bug.

  • Comment about 2 months ago →
    🇬🇧United Kingdom catch

    Too late to fix this for 9.5 sites, even if we backported something they'd need to update to the newer 9.5 release to get 10.x recommended.

    However given we're planning to support 10.x right up until around 12.0.0's release, this is more likely to happen again since the Drupal 10 EOL will be a lot closer to 12.0.0's release date. A bit of time before we get there, but moving to major.

  • Comment about 2 months ago →
    🇬🇧United Kingdom longwave UK

    Also just run into this on a small site that was way behind and has just been updated to 9.5.11, it's also recommending going to 11.0.0-rc1 or 10.2.2 as a security update, and doesn't mention 10.3 at all.

  • First commit to issue fork.
  • Merge request !8895add test → (Closed) created by quietone
  • Comment about 2 months ago →
    🇳🇿New Zealand quietone New Zealand

    On 11.x, I changed the Drupal version to 9.5.11 and checked for updates. Here are the results.

    The new test uses a release history with only the supported releases, 10.2.0, 10.2.2, 11.0.0-alpha1, and 11.0.0-beta1. And runs with an installed release of 9.x.y, And a sample output from the test.

    Those indicate this is fixed, although I don't know when.

  • Pipeline finished with Success
    about 2 months ago
    Total: 551s
    #232223
  • Status changed to Postponed: needs info about 2 months ago
  • Comment about 2 months ago →
    🇬🇧United Kingdom longwave UK

    This was solved in 🐛 Never show a "Not supported!" version as "Recommended" Needs work . I just patched my 9.5 site with the changes from that issue and get a better message:

    So if this is fixed in newer versions and there is nothing now that can be done in 9.5, I think this can be closed as duplicate?

  • Status changed to Active about 2 months ago
  • Comment about 2 months ago →
    🇳🇿New Zealand quietone New Zealand

    @longwave, thanks for identifying what issue fixed this problem.

    I do think that the test case added here should be added. The test fixture added here is different from the existing ones in that it has a Major+2 version with alpha and beta releases. I am setting to Active to self review and add comments.

  • Pipeline finished with Success
    about 1 month ago
    Total: 492s
    #238121
  • Status changed to Needs review about 1 month ago
  • Comment about 1 month ago →
    🇳🇿New Zealand quietone New Zealand

    I changed the release numbers in the test fixtures to be more like what is already in the fixture directory. And added comments.

  • Status changed to RTBC about 1 month ago
  • Comment about 1 month ago →
    🇺🇸United States smustgrave

    Additional test coverage is always good

    Imagine if Microsoft thought about that :)

  • Comment 22 days ago →
    System Message
    • catch → committed 8a3146a1 on 10.3.x 
      Issue #3461690 by quietone, dww, longwave: Add tests for updates should...
  • Comment 22 days ago →
    System Message
    • catch → committed 08c9d30b on 10.4.x 
      Issue #3461690 by quietone, dww, longwave: Add tests for updates should...
  • Comment 22 days ago →
    System Message
    • catch → committed 153fe548 on 11.0.x 
      Issue #3461690 by quietone, dww, longwave: Add tests for updates should...
  • Comment 22 days ago →
    🇬🇧United Kingdom catch

    Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

  • Comment 22 days ago →
    System Message
    • catch → committed 44740961 on 11.x 
      Issue #3461690 by quietone, dww, longwave: Add tests for updates should...
  • Status changed to Fixed 22 days ago
  • Comment 22 days ago →
    System Message
  • Comment 8 days ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024