Never show a "Not supported!" version as "Recommended"

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

quietone → closed merge request !1368

This does fix the problem in the issue summary. This also needs to figure out the recommended version in this situation. But since this is a rare situation that can be done in a followup. That followup may be a special case for #3252190: Store all installable releases in update_calculate_project_update_status() →

Seems I was wrong about moving that block of code.

In any case, let's get some eyes on this.

So in #27 @quietone are you saying we don't need the follow up?

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Yes, I now think a follow up is not needed. If there is no other release to recommend. And the existing text does provide recommended actions.

In that case the changes appear fine.

Only open thread I see is the question for

Why allow more than $index. Is there a risk of having duplicates not caught?

. Tracked it down to
https://www.drupal.org/project/drupal/issues/3102724#comment-13477991 → I don't see much discussion about it, but feel the idea was only testing 1 at a time?

But testing the $index makes sense and expands usefulness of the function to test various numbers.

Looks good.

The fix and additional test coverage look great. Committed and pushed 77b659b573 to 11.x and fb156f9317 to 10.3.x. Thanks!

Will discuss with other committers whether to backport to 10.2.x, I think this is a relatively important bug to fix but it does contain a newly untranslated string.

This doesn't cleanly cherry-pick due to other changes in 10.3.x/11.x that aren't in 10.2.x, as nice as it would be to fix I'm not sure it's worth the effort of backporting it now.

longwave → closed merge request !4565

Automatically closed - issue fixed for 2 weeks with no activity.