- Issue created by @mherchel
- 🇺🇸United States mherchel Gainesville, FL, US
mherchel → changed the visibility of the branch 3461284-prevent-simultaneous-openclose to hidden.
- 🇺🇸United States mherchel Gainesville, FL, US
mherchel → changed the visibility of the branch 3461284-prevent-simultaneous-openclose to active.
- Merge request !8761Prevent simultaneous opening/closing of submenus on click. → (Closed) created by mherchel
- Status changed to Needs review
6 months ago 2:13pm 14 July 2024 - 🇺🇸United States mherchel Gainesville, FL, US
MR ready for review. Playing around with it, I ended up at 500ms.
- Status changed to RTBC
6 months ago 7:27am 16 July 2024 - 🇷🇸Serbia finnsky
Thanks for working on this annoying problem.
I looked and confirm that everything works well.In the future I would remove the timeouts and replace them with animation times. But for now we can move on like this.
- Status changed to Needs work
6 months ago 9:13am 17 July 2024 - Status changed to Needs review
6 months ago 12:11pm 17 July 2024 - 🇺🇸United States mherchel Gainesville, FL, US
Fixed!
- Data attribute prefixed with
drupal - When I set the attribute, I set the value to
'true'. Setting it to an empty string didn't feel right when I was checking the value of it. I'd have to either 1) check for the empty string 2) check if not undefined 3) use triple bangs (!!!)... all of which seemed kinda weird for me. Either way, I think it's good now!
- Data attribute prefixed with
- Status changed to RTBC
6 months ago 2:46pm 17 July 2024 - Status changed to Fixed
6 months ago 8:22pm 17 July 2024 - 🇫🇷France nod_ Lille
Committed and pushed c1708b3265 to 11.x and 9c482363bb to 11.0.x and 1dcc53dd09 to 10.4.x and eacdda9692 to 10.3.x. Thanks!
- 🇺🇸United States mherchel Gainesville, FL, US
🙌 🙌
Yay! Thanks @finnsky and @nod_
Automatically closed - issue fixed for 2 weeks with no activity.