- Issue created by @quietone
- Issue was unassigned.
- Status changed to Needs review
6 months ago 8:37am 15 July 2024 - Status changed to RTBC
6 months ago 2:38pm 15 July 2024 - 🇺🇸United States smustgrave
Reviewing the proposed words and they line up with the MR
Reviewing the the changes in the test files and they make sense to me
Think this is good.
- Status changed to Needs work
6 months ago 4:28pm 20 July 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
6 months ago 4:41am 21 July 2024 - Status changed to RTBC
6 months ago 6:20pm 21 July 2024 - First commit to issue fork.
- Status changed to Needs review
5 months ago 9:15am 29 July 2024 - 🇬🇧United Kingdom catch
When I tried to commit this locally, I got the following errors:
./core/tests/Drupal/Tests/Core/EventSubscriber/RssResponseCdataTest.php:95:49 - Unknown word (xfbml) ./core/tests/Drupal/Tests/Core/EventSubscriber/RssResponseCdataTest.php:97:33 - Unknown word (jssdk)Not sure if I'm missing something or if it's a real problem, but would be good to get confirmation either way.
- 🇳🇿New Zealand quietone
Needed to make a change for a new test file, RssResponseCdataTest.php.
- Status changed to RTBC
5 months ago 12:11pm 29 July 2024 - Status changed to Needs work
5 months ago 7:12am 6 August 2024 - Status changed to RTBC
5 months ago 7:38am 6 August 2024 - 🇳🇿New Zealand quietone
There were no conflicts with the rebase so returning to RTBC.
- Status changed to Fixed
5 months ago 8:44am 6 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.