Save button missing in modal for editing using the Front End Editing module

I have just raised this to major which I think is fair given that the issue blocks all site editing using the Front End Editing (FEE) module and that might cause some anxiety to content editors who rely on the FEE module and who are not in a position to quickly roll back to an earlier gin theme version.

I can confirm that after applying the MR via the patch file, we can now use the Front End Editing module again — the Save button is back ;-)

Super fast work there, thank you!

Hi @saschaeggi, I've applied the MR as patch and the patch applied successfully. The issue of Save button missing while using frontend_editing module has been resolved successfully through patch. Now using frontend_editing module the quick edit done can be saved successfully through the save button. Attaching before and after fixes screenshots for reference. Hence moving the issue status to Reviewed & tested.

Thanks!

I have just realised that although this is fixed for the EDIT form, the Save button is still missing when you try to insert a brand new Paragraph - i.e. I' don't think the ADD form has been taken into account too.

Thanks all.

@SirClickalot can you please open an MR with the additional forms we need to check for? Thanks

@saschaeggi I'm afraid I do not know how to open an MR - sorry!

However, the form id appears to be paragraph_text_entity_add_form and looking into the last patch from MR: 454, I can see the addition of…

strpos($form_id, '_entity_add_form') !== FALSE ||

…would do it.

Hi @SirClickalot, I have been trying to reproduce the issue which is mentioned in #11 🐛 Save button missing in modal for editing using the Front End Editing module Needs work but I couldn't find an option to add a new paragraph to a page using Frontend Editing module. Could you please specify the steps to reproduce?
Note:- I'm able to add new paragraph to a new/existing page and save it using normal editing.

Sure,

It's a fundamental whizzy feature of the Front End Editing module...

What you will find — when using Gin as the backend theme — is that having chosen one of the available Paragraphs types, you can happily edit away but cannot Save it.

I hope that helps.

Due to some reason, I'm not getting that '+' icon to add new paragraph. That's why I'm not able to reproduce the issue. I tried by re-installing the module multiple times but still facing this issue.

That could possibly be because you have not enable the particular Paragraph type at: /admin/config/frontend-editing/entity-bundle-restrictions

It's already enabled. Because then only the edit button will be available in the frontend for the paragraphs.

Hi, I've added the Save button for adding a new paragraph using frontend_editing module. Attaching the before and after video clips for reference. Please review the MRs.

I can confirm that MR:341817 fixes the issue for me.

Thank you @tirupati_singh →

The MR !473 seems to contain untelated changes to dist/js/more_actions.js

Also can you check if the MR in https://www.drupal.org/project/gin/issues/3463796 🐛 Ensure sticky action buttons to work with modals and ajax refresh-calls Needs review will solve this issue?

@saschaeggi, I've removed the unrelated changes to dist/js/more_actions.js in MR !473. Please review the changes.

I've applied the MR !479 as a patch and it applied with no errors. After applying the patch, the MR didn't resolve the issue.The Save button missing issue persists when Enable sticky action buttons is enabled.

Thanks for testing, pushed the fix 👍

Automatically closed - issue fixed for 2 weeks with no activity.