- Issue created by @bhaveshdas
- Status changed to Needs review
2 months ago 12:23pm 8 July 2024 - ๐ฎ๐ณIndia bhaveshdas
I have fixed all phpcs issues could you please review it.
Thanktou !
- Status changed to Needs work
2 months ago 12:01pm 9 July 2024 - ๐ต๐ญPhilippines cleavinjosh
Hi @bhaveshdas,
I applied MR!1 and I encountered an error.
โ cache_control_headers git:(main) โ curl https://git.drupalcode.org/project/cache_control_headers/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1702 0 1702 0 0 4346 0 --:--:-- --:--:-- --:--:-- 4352 patching file README.md patching file src/EventSubscriber/CacheControlResponseSubscriber.php Hunk #1 FAILED at 2. 1 out of 1 hunk FAILED -- saving rejects to file src/EventSubscriber/CacheControlResponseSubscriber.php.rej โ cache_control_headers git:(main) โ
Please check and advise.
Thank you. - Issue was unassigned.
- ๐ฎ๐ณIndia dev2.addweb
nilesh.addweb โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 2 months ago 8:37am 11 July 2024 - ๐ฎ๐ณIndia dev2.addweb
Hello,
Try this MR !2 using the (1.0.x-dev) version.
- Status changed to Needs work
about 2 months ago 8:50am 11 July 2024 - ๐ต๐ญPhilippines cleavinjosh
Hi @nilesh.addweb,
I applied MR!2 on 1.0.x-dev and it was applied smoothly. However I still encountered an issue after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
.โ cache_control_headers git:(1.0.x) curl https://git.drupalcode.org/project/cache_control_headers/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 963 0 963 0 0 2620 0 --:--:-- --:--:-- --:--:-- 2616 patching file README.md โ cache_control_headers git:(1.0.x) โ .. โ contrib git:(main) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml cache_control_headers FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/cache_control_headers/src/EventSubscriber/CacheControlResponseSubscriber.php ------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheableResponseInterface. ------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------------------------------- Time: 190ms; Memory: 10MB โ contrib git:(main) โ
Thank you.
- Status changed to Needs review
about 2 months ago 10:22am 24 July 2024 - ๐ฎ๐ณIndia dev2.addweb
I have updated MR !2 and fixed phpcs issue mention in #9. Please review it.
- Status changed to RTBC
about 1 month ago 11:19am 25 July 2024 - ๐ต๐ญPhilippines cleavinjosh
Hi @nilesh.addweb,
I applied MR!2, it was applied smoothly and fixed the phpcs issue in comment #9.
โ cache_control_headers git:(1.0.x) curl https://git.drupalcode.org/project/cache_control_headers/-/merge_requests/2.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1699 0 1699 0 0 2380 0 --:--:-- --:--:-- --:--:-- 2379 patching file README.md patching file src/EventSubscriber/CacheControlResponseSubscriber.php โ cache_control_headers git:(1.0.x) โ .. โ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml cache_control_headers โ contrib
I will now move the status to Reviewed and tested by the community
Thank you.