- Issue created by @mikelutz
- Status changed to Needs review
2 months ago 2:46pm 6 July 2024 - Status changed to RTBC
2 months ago 1:02am 8 July 2024 - πΊπΈUnited States smustgrave
Deprecation versions seem correct. Has simple test case for it. CR is there. Believe this is good
- π¬π§United Kingdom catch
Went ahead and committed this without the test coverage:
- we generally don't add deprecation testing unless there's an actual bc layer involved, just triggering the deprecation is enough.
- getMockForAbstractClass() is deprecated in phpunit 10 and we only don't need to add it to the baseline because it's being called in a @legacy test. It would mean having to remove or refactor this test before we can update to phpunit 11 - another reason to skip test coverage.
Committed/pushed to 11.x, thanks!
- Status changed to Fixed
about 2 months ago 11:56am 17 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.