Integrate with scheduler module

Yeah this is a really nice and useful thing. Could you eventually provide a MR @SocialNicheGuru?

Maybe we should ask for maintainership to push things forward in the ad module? Seesm quite inactive, but still useful for Drupal!

I am using http://drupal.org/project/eca now instead.

Hi @SocialNicheGuru thanks for the feedback! Are you using it as replacement for ads or for scheduler with ads?

Scheduling the ads using ECA

Thanks for the feedback @SocialNicheGuru. Still I think an integration would make sense, as scheduler module is very widely used with clear focus.

Since this is part of our list of improvements for 11.x, we can simply tackle this as a follow-up to 📌 [META] 11.x feature updates Active .

Let's do this as follow-up. @lrwebks has a list of possible Scheduler issues that might help with the implementation.

📌 [META] 11.x feature updates Active will provide the basic implementation of the submodule, that will be finished here. I have made a support request to the scheduler maintainers for a proper guideline of implementing the scheduler plugin as the docs are a bit unclear and all over the place. ( 💬 How to integrate scheduler with custom / contrib entity types? Active )

PP on 💬 How to integrate scheduler with custom / contrib entity types? Active

@lrwebks the submodule currently breaks CI pipeline. Can we please comment out its tests in master, until this one is resolved? (Re-comment in in a MR here)

Thanks!

See my comment in the CI issue ( https://www.drupal.org/project/ad/issues/3525832#comment-16134384 📌 Fix failing tests / CI pipeline and clean-up code Active ).

All done, please review!

Side note @lrwebks please ALWAYS name task links identical to the route they represent. This is the Drupal standard and just costed me a bunch of time:

ad_content.admin:
  title: 'Advertisements'
  route_name: entity.ad_content.collection
  base_route: system.admin_content

@ad_content.links.task.yml

Damn, the missing revision data table entity key just swallowed half of my day...

POSTPONED on 🐛 Fix missing mandatory "AdContent" entity revision keys Active

Alright, 🐛 Fix missing mandatory "AdContent" entity revision keys Active is resolved and all is done! Please review!

Great, let's use it!