- Issue created by @Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Moving this from project_browser queue to project queue per @leslieg.
- Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
I'm going to take this one and see if one of my interns can help today. Adding existing logo to summary.
- Status changed to Needs work
4 months ago 11:25pm 17 July 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Looks good but the size is 12KB. Can you get it down to 10KB?
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Jacob mentioned to me that he couldn't get this lower than 12KB so I'll check in Slack for ideas.
- Issue was unassigned.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Unassigning from me but I'll follow up once I hear back in Slack.
- 🇮🇪Ireland lostcarpark
Diagonal gradients are difficult to compress.
12K is close enough that it's not a big issue.
However, vertical gradients tend to compress much better. It would be interesting to see how it looks with the inner gradiant going left to right, and the outer gradient going right to left. If it doesn't look good or achieve enough of a file size saving, I'd say we just accept this one being slightly over size.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Sounds good. Thanks for the feedback 👍
- 🇺🇸United States paulmckibben Atlanta, GA
Folks, I'll defer to your expertise here, as my graphics skills are pretty basic. If somebody would like to offer a new logo with the gradient changes that @lostcarpark suggests, I'm happy to commit it! Otherwise, if we want to continue with the existing logo, I'll be happy to commit that instead.
- Status changed to Needs review
3 months ago 9:31pm 12 August 2024 - 🇫🇷France dydave
Managed getting the image from #4 down to 9.95KB by reducing the colors to 64, with pngquant, without losing "too" much quality, see:
The smoothness of the gradient is a bit degraded, but if the logo is displayed in a small size (which I assume it is supposed to) perhaps that wouldn't be too visible?
See for example:
If more compression is required, then reducing the colors further to 32 or 16 would get the size further down to 8KB or 7KB, but the gradient would look more degraded.
Otherwise, the changes suggested at #8 might help getting better results, but my design skills are too limited to implement them.
Setting issue back to Needs review as the compressed image in this comment should answer the request above at #5 to get the image size below 10KB.
Hope that helps.
Thanks in advance for your feedback and reviews! - Status changed to RTBC
3 months ago 7:17am 13 August 2024 Hi @DYdave,
Your argument seems to be legit, as in PB I think the logos will be displayed in small thumbnails, so the degradation of the gradient won't be that much visible. This compression looks good to me as well as meets the criteria as well. Hence moving it to RTBC from my end!- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Note that the logo will be in a bigger size for PB vs as shown on the project’s page but hopefully this reduced version is still okay
- Merge request !42Issue #3459382: Project Browser: Updated logo for Colorbox. → (Merged) created by dydave
- Status changed to Fixed
3 months ago 12:45am 5 September 2024 - 🇺🇸United States paulmckibben Atlanta, GA
Thanks, everyone! This has been merged.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇫🇷France dydave
Thanks a lot Paul (@paulmckibben) for getting module's logo added: It looks great on the project page!
I realize the issue is now closed and this message is just a bit too late ... but I'm hoping you might perhaps receive and see the email notification:
Could you please edit the project page ( https://www.drupal.org/project/colorbox → ) and hide or remove the Colorbox logo, since it is now displayed next to the module's page title?
As suggested in the Project Browser integration guidelines at:
https://www.drupal.org/docs/contributed-modules/project-browser/module-m... →5. If you previously added a logo as the first image on the Drupal.org project page, please remove it.
That's really minor, but we forgot to mention it earlier.
Thanks in advance! - 🇺🇸United States paulmckibben Atlanta, GA
@dydave, thanks for letting me know about this. I removed the logo from the project page images.
- 🇫🇷France dydave
Thanks Paul! (@paulmckibben)
You're a super nice maintainer! Always positive, helpful, crediting everyone and super reactive!It's a great pleasure to be able to work with you! 🙂
I've seen your feedback on the ESLint ticket ... it's a hard one and will take a bit of time, but I'm definitely going to get back to you on this when I have some time.
Thanks again for all the great help maintaining the module and super helpful feedback!
Cheers!