- Issue created by @DieterHolvoet
- Merge request !450Stop hardcoding menu__toolbar__admin as theme hook → (Merged) created by DieterHolvoet
- Status changed to Needs review
2 months ago 8:16am 4 July 2024 - 🇨🇭Switzerland saschaeggi Zurich
I'm trying to understand why this is needed. Are you using a different (custom) menu for the editor?
- Status changed to Postponed: needs info
2 months ago 3:44pm 4 July 2024 - 🇧🇪Belgium DieterHolvoet Brussels
Right, I assumed 'admin' and 'editor' reference the user role, but they reference the menu name. We use a different menu in the admin toolbar for editors using the Admin Menu Swap module → .
- Status changed to Needs review
about 2 months ago 11:54am 14 July 2024 - Status changed to RTBC
about 2 months ago 6:13pm 22 July 2024 - 🇮🇳India Tirupati_Singh
Hi, I've applied the MR as patch and it applied with no errors. I've created a new role with some administrative permissions and can confirm that the Logo is not being shown for the non-admin role users. After applying the patch the issue resolves successfully. This issue is only occurring while using the Admin Menu Swap module and the menu icons is also not being rendered when using this module for swapping menu for different roles. I have attached the before and after screenshots with Admin Menu Swap config for the role, for reference.
- Status changed to Fixed
about 1 month ago 11:52am 1 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.