- Issue created by @selinav
- First commit to issue fork.
- Merge request !12Issue #3458794: unable to choose image style after download → (Merged) created by jannakha
- Status changed to Needs review
4 months ago 9:11am 17 July 2024 - 🇦🇺Australia jannakha Brisbane!
Before patch:
The error is caused by outdated dependency:
After patch:
Updated CKEditor5 core dependency to Drupal 10.3.1's (CKEditor v41.3.1)
Update maybe required when 10.4 is released (CKEditor5 will be updated to v42.0.0)
- 🇫🇷France selinav
I use CKeditor 5 core with Drupal 10.3.1.
Where is the patch ?
- 🇦🇺Australia jannakha Brisbane!
@selinav
here's how apply patches from gitlab MR - https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →you don't need to download any new libraries, only apply patch as described
Your contributions to this module and Drupal for any upgrades/updates/testing are welcome!
- 🇫🇷France selinav
Thank you.
I'm not too comfortable with composer.
For basic operations: install, update, delete, it's fine, but as soon as I get an error message, I'm lost.I followed this tutorial, but it doesn't work: https://vazcell.com/blog/how-apply-patch-drupal-9-and-drupal-10-composer
I have this in "extra" section of my composer.json
"extra": {
"composer-exit-on-patch-failure": true,
"patchLevel": {
"drupal/core": "-p2"
},
"drupal-scaffold": {
"locations": {
"web-root": "web/"
}
},
"installer-paths": {
"web/core": ["type:drupal-core"],
"web/libraries/{$name}": ["type:drupal-library"],
"web/modules/contrib/{$name}": ["type:drupal-module"],
"web/profiles/contrib/{$name}": ["type:drupal-profile"],
"web/themes/contrib/{$name}": ["type:drupal-theme"],
"drush/Commands/contrib/{$name}": ["type:drupal-drush"]
},
"inline_responsive_images": {
"3458794-unable-to-choose": "https://git.drupalcode.org/project/inline_responsive_images/-/merge_requ..."
}
}I get this message in my command lines
C:\wamp64\www\codiald10>composer update Composer could not detect the root package (drupal-composer/drupal-project) version, defaulting to '1.0.0'. See https://getcomposer.org/root-version > DrupalProject\composer\ScriptHandler::checkComposerVersion Loading composer repositories with package information Updating dependencies Lock file operations: 0 installs, 20 updates, 0 removals - Upgrading chi-teck/drupal-code-generator (3.3.0 => 3.6.1) - Upgrading consolidation/annotated-command (4.9.2 => 4.10.0) - Upgrading consolidation/log (3.0.0 => 3.1.0) - Upgrading consolidation/output-formatters (4.3.2 => 4.5.0) - Upgrading consolidation/site-alias (4.0.1 => 4.1.0) - Upgrading consolidation/site-process (5.2.0 => 5.4.0) - Upgrading dflydev/dot-access-data (v3.0.2 => v3.0.3) - Upgrading drupal/ds (3.18.0 => 3.22.0) - Upgrading drupal/easy_breadcrumb (2.0.5 => 2.0.7) - Upgrading drupal/slick (2.10.0 => 2.11.0) - Upgrading drush/drush (12.4.3 => 12.5.2) - Upgrading grasmash/yaml-cli (3.1.0 => 3.2.1) - Upgrading guzzlehttp/guzzle (7.8.1 => 7.8.2) - Upgrading guzzlehttp/promises (2.0.2 => 2.0.3) - Upgrading guzzlehttp/psr7 (2.6.2 => 2.6.3) - Upgrading league/container (4.2.0 => 4.2.2) - Upgrading nikic/php-parser (v5.0.0 => v5.1.0) - Upgrading psy/psysh (v0.12.0 => v0.12.4) - Upgrading twbs/bootstrap (v5.3.2 => v5.3.3) - Upgrading webflo/drupal-finder (1.2.2 => 1.3.1) Writing lock file Installing dependencies from lock file (including require-dev) Package operations: 0 installs, 20 updates, 0 removals - Downloading consolidation/log (3.1.0) - Downloading guzzlehttp/psr7 (2.6.3) - Downloading guzzlehttp/promises (2.0.3) - Downloading guzzlehttp/guzzle (7.8.2) - Downloading twbs/bootstrap (v5.3.3) Failed to download drupal/ds from source: git was not found in your PATH, skipping source download Now trying to download from dist - Downloading drupal/ds (3.22.0) Failed to download drupal/easy_breadcrumb from source: git was not found in your PATH, skipping source download Now trying to download from dist - Downloading drupal/easy_breadcrumb (2.0.7) - Downloading drupal/slick (2.11.0) - Downloading webflo/drupal-finder (1.3.1) - Downloading nikic/php-parser (v5.1.0) - Downloading psy/psysh (v0.12.4) - Downloading league/container (4.2.2) - Downloading dflydev/dot-access-data (v3.0.3) - Downloading grasmash/yaml-cli (3.2.1) - Downloading consolidation/site-alias (4.1.0) - Downloading consolidation/site-process (5.4.0) - Downloading consolidation/output-formatters (4.5.0) - Downloading consolidation/annotated-command (4.10.0) - Downloading chi-teck/drupal-code-generator (3.6.1) - Downloading drush/drush (12.5.2) - Upgrading consolidation/log (3.0.0 => 3.1.0): Extracting archive - Upgrading guzzlehttp/psr7 (2.6.2 => 2.6.3): Extracting archive - Upgrading guzzlehttp/promises (2.0.2 => 2.0.3): Extracting archive - Upgrading guzzlehttp/guzzle (7.8.1 => 7.8.2): Extracting archive - Upgrading twbs/bootstrap (v5.3.2 => v5.3.3): Extracting archive - Removing drupal/ds (3.18.0) - Removing drupal/easy_breadcrumb (2.0.5) - Upgrading drupal/slick (2.10.0 => 2.11.0): Extracting archive - Upgrading webflo/drupal-finder (1.2.2 => 1.3.1): Extracting archive - Upgrading nikic/php-parser (v5.0.0 => v5.1.0): Extracting archive - Upgrading psy/psysh (v0.12.0 => v0.12.4): Extracting archive - Upgrading league/container (4.2.0 => 4.2.2): Extracting archive - Upgrading dflydev/dot-access-data (v3.0.2 => v3.0.3): Extracting archive - Upgrading grasmash/yaml-cli (3.1.0 => 3.2.1): Extracting archive - Upgrading consolidation/site-alias (4.0.1 => 4.1.0): Extracting archive - Upgrading consolidation/site-process (5.2.0 => 5.4.0): Extracting archive - Upgrading consolidation/output-formatters (4.3.2 => 4.5.0): Extracting archive - Upgrading consolidation/annotated-command (4.9.2 => 4.10.0): Extracting archive - Upgrading chi-teck/drupal-code-generator (3.3.0 => 3.6.1): Extracting archive - Upgrading drush/drush (12.4.3 => 12.5.2): Extracting archive 0/20 [>---------------------------] 0% - Installing drupal/ds (3.22.0): Extracting archive - Installing drupal/easy_breadcrumb (2.0.7): Extracting archive 18/20 [=========================>--] 90% Failed to extract drush/drush: (2) "C:\Program Files\7-Zip\7z.EXE" x -bb0 -y C:\wamp64\www\codiald10\vendor\composer\tmp-2652c44d3bb131960a7803f557cf3519.zip -oC:\wamp64\www\codiald10\vendor\composer\487c181a ERROR: Cannot create symbolic link : Le client ne dispose pas d'un privil�ge n�cessaire. : C:\wamp64\www\codiald10\vendor\composer\487c181a\drush-ops-drush-4aebed8\docs\contribute\CONTRIBUTING.md ERROR: Cannot create symbolic link : Le client ne dispose pas d'un privil�ge n�cessaire. : C:\wamp64\www\codiald10\vendor\composer\487c181a\drush-ops-drush-4aebed8\docs\drush_logo-black.png ERROR: Cannot create symbolic link : Le client ne dispose pas d'un privil�ge n�cessaire. : C:\wamp64\www\codiald10\vendor\composer\487c181a\drush-ops-drush-4aebed8\docs\img\favicon.ico ERROR: Cannot create symbolic link : Le client ne dispose pas d'un privil�ge n�cessaire. : C:\wamp64\www\codiald10\vendor\composer\487c181a\drush-ops-drush-4aebed8\docs\misc\icon_PhpStorm.png The archive may contain identical file names with different capitalization (which fails on case insensitive filesystems) Unzip with 7z command failed, falling back to ZipArchive class Generating autoload files 46 packages you are using are looking for funding. Use the `composer fund` command to find out more! > DrupalProject\composer\ScriptHandler::createRequiredFiles No security vulnerability advisories found. C:\wamp64\www\codiald10>composer update Composer could not detect the root package (drupal-composer/drupal-project) version, defaulting to '1.0.0'. See https://getcomposer.org/root-version > DrupalProject\composer\ScriptHandler::checkComposerVersion Loading composer repositories with package information Updating dependencies Nothing to modify in lock file Installing dependencies from lock file (including require-dev) Nothing to install, update or remove Generating autoload files 46 packages you are using are looking for funding. Use the `composer fund` command to find out more! > DrupalProject\composer\ScriptHandler::createRequiredFiles No security vulnerability advisories found.
I don't know how to correct it.
And, I can't download the source code zip file of https://git.drupalcode.org/issue/inline_responsive_images-3458794/-/tree... because I get this message
"Unsupported GitLab operation
You have attempted an action in GitLab that Drupal.org does not currently support.
Please see our GitLab documentation for more information."How to download files or apply patch easily ?
Thank you for your help
- 🇦🇺Australia jannakha Brisbane!
if you've been installing dependencies using composer:
once you added patches to composer (extra patch for responsive images if you're using those):
"patches": { "drupal/core": { "Responsive image width/height values are not used from fallback image style: https://www.drupal.org/project/drupal/issues/3377420": "https://git.drupalcode.org/project/drupal/-/merge_requests/7248.diff" }, "drupal/inline_responsive_images": { "unable to choose image style after download: https://www.drupal.org/project/inline_responsive_images/issues/3458794": "https://git.drupalcode.org/project/inline_responsive_images/-/merge_requests/12.diff", "not a supported key getting issue with ckeditor5: https://www.drupal.org/project/inline_responsive_images/issues/3460644": "https://git.drupalcode.org/project/inline_responsive_images/-/merge_requests/13.diff", } }
try running
```
composer install --prefer-source
```the issue you're having is incorrect file from gitlab (you've got https://git.drupalcode.org/project/inline_responsive_images/-/merge_requ... - which returns 404, you need to use https://git.drupalcode.org/project/inline_responsive_images/-/merge_requ...
)composer is not that scary - it really helps with management of dependencies, versions and security!
hope that helps!PS - you can also just download patch (https://git.drupalcode.org/project/inline_responsive_images/-/merge_requ... to your local drive and apply it from local path)
- 🇺🇸United States seattlehimay
Not original poster, but this patch solved my issue. I appreciate you posting the code for composer, as I hadn't patched with a merge request before.
(Note that there is an extra trailing comma after 13.diff", that may catch someone...)
- 🇦🇺Australia jannakha Brisbane!
Good catch!
I fixed comma in the patch example. - 🇫🇷France selinav
Thank you for the reply.
I put your code in my composer file.
"patches": { "drupal/core": { "Responsive image width/height values are not used from fallback image style: https://www.drupal.org/project/drupal/issues/3377420": "https://git.drupalcode.org/project/drupal/-/merge_requests/7248.diff" }, "drupal/inline_responsive_images": { "unable to choose image style after download: https://www.drupal.org/project/inline_responsive_images/issues/3458794": "https://git.drupalcode.org/project/inline_responsive_images/-/merge_requests/12.diff", "not a supported key getting issue with ckeditor5: https://www.drupal.org/project/inline_responsive_images/issues/3460644": "https://git.drupalcode.org/project/inline_responsive_images/-/merge_requests/13.diff" } }
It starts well, but I get an error line 331.
C:\wamp64\www\codiald10>composer install --prefer-source Composer could not detect the root package (drupal-composer/drupal-project) version, defaulting to '1.0.0'. See https://getcomposer.org/root-version Gathering patches for root package. Removing package drupal/core so that it can be re-installed and re-patched. - Removing drupal/core (10.3.1) Removing package drupal/inline_responsive_images so that it can be re-installed and re-patched. - Removing drupal/inline_responsive_images (3.0.0-beta1) Deleting web/modules/contrib/inline_responsive_images - deleted Deleting web/core - deleted > DrupalProject\composer\ScriptHandler::checkComposerVersion Installing dependencies from lock file (including require-dev) Verifying lock file contents can be installed on current platform. Package operations: 2 installs, 0 updates, 0 removals Failed to download drupal/core from source: git was not found in your PATH, skipping source download Now trying to download from dist Failed to download drupal/inline_responsive_images from source: git was not found in your PATH, skipping source download Now trying to download from dist Gathering patches for root package. Gathering patches for dependencies. This might take a minute. - Installing drupal/core (10.3.1): Extracting archive - Installing drupal/inline_responsive_images (3.0.0-beta1): Extracting archive - Applying patches for drupal/core https://git.drupalcode.org/project/drupal/-/merge_requests/7248.diff (Responsive image width/height values are not used from fallback image style: https://www.drupal.org/project/drupal/issues/3377420) Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/project/drupal/-/merge_requests/7248.diff In Patches.php line 331: Cannot apply patch Responsive image width/height values are not used from fallback image style: https://www.drupal. org/project/drupal/issues/3377420 (https://git.drupalcode.org/project/drupal/-/merge_requests/7248.diff)! install [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--download-only] [--dev] [--no-suggest] [--no-dev] [--no-autoloader] [--no-progress] [--no-install] [--audit] [--audit-format AUDIT-FORMAT] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--] [<packages>...]
What am I doing wrong?
Thank you for your help.
- 🇫🇷France selinav
Now, menu to select image style well displays but I can't choose image style responsive (no dropdown).
When I go to admin/config/content/formats/manage/full_html
I check my responsive styles but they aren't saved cause to error message:"La clé "css_classes" n'est pas prise en charge." (The "css_classes" key is not supported.)
More over, I can't change the filter processing order to put at the end "display responsive image styles".
- 🇦🇺Australia jannakha Brisbane!
That’s another issue
https://www.drupal.org/project/inline_responsive_images/issues/3460644 🐛 'image_style_*' is not a supported key getting issue with ckeditor5 Needs work
- Status changed to RTBC
4 months ago 12:54am 7 August 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Patch applies and works. Thank you 🍰
-
vladimiraus →
committed 49896089 on 3.x authored by
jannakha →
Issue #3458794 by jannakha, selinav, seattlehimay, vladimiraus: unable...
-
vladimiraus →
committed 49896089 on 3.x authored by
jannakha →
- Status changed to Fixed
about 1 month ago 5:37am 14 October 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Thanks, everyone! Committed! 🍰
Automatically closed - issue fixed for 2 weeks with no activity.