Add string return typehints to protected test helper methods

There a script that's picking these up?

Kind of. There are some rector rules mentioned in the parent issue but they pick up more than just string returns so it's manually manipulated. I realise it probably hasn't found everything but I think it's reasonable to knock off this low hanging fruit.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Going to agree that this seems like a good size now. Any stragglers can be hit later.

Noting that there is a change to a base class here, core/tests/Drupal/FunctionalJavascriptTests/PerformanceTestBase.php

Let's get this into 11.x and 10.4.x and see if anything breaks downstream, hopefully nothing. I think it's highly unlikely the PerformanceTestBase method will be overridden.

Committed and pushed 22e2a1285a to 11.x and 67b91bcb42 to 10.4.x. Thanks!

longwave → closed merge request !8621

Automatically closed - issue fixed for 2 weeks with no activity.