- Issue created by @mstrelan
- Merge request !8621Issue #3458422: Add string return typehints to protected test helper methods → (Closed) created by mstrelan
- Status changed to Needs review
2 months ago 4:52am 2 July 2024 - 🇦🇺Australia mstrelan
Kind of. There are some rector rules mentioned in the parent issue but they pick up more than just string returns so it's manually manipulated. I realise it probably hasn't found everything but I think it's reasonable to knock off this low hanging fruit.
- Status changed to Needs work
about 2 months ago 12:09pm 10 July 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 months ago 1:04am 15 July 2024 - Status changed to RTBC
about 2 months ago 11:51pm 17 July 2024 - 🇺🇸United States smustgrave
Going to agree that this seems like a good size now. Any stragglers can be hit later.
- 🇳🇿New Zealand quietone New Zealand
Noting that there is a change to a base class here, core/tests/Drupal/FunctionalJavascriptTests/PerformanceTestBase.php
-
longwave →
committed 67b91bcb on 10.4.x
Issue #3458422 by mstrelan, smustgrave: Add string return typehints to...
-
longwave →
committed 67b91bcb on 10.4.x
-
longwave →
committed 22e2a128 on 11.x
Issue #3458422 by mstrelan, smustgrave: Add string return typehints to...
-
longwave →
committed 22e2a128 on 11.x
- Status changed to Fixed
16 days ago 5:29pm 22 August 2024 - 🇬🇧United Kingdom longwave UK
Let's get this into 11.x and 10.4.x and see if anything breaks downstream, hopefully nothing. I think it's highly unlikely the PerformanceTestBase method will be overridden.
Committed and pushed 22e2a1285a to 11.x and 67b91bcb42 to 10.4.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.