When the height of the dialog title bar is a subpixel value and the height of the dialog is set to a percentage, the resetSize function in dialog.position.js will flip between setting the height to a fixed value and "auto" every time it is called because adjustedValue is rounded by running it through parseInt, whereas the actual height it is being compared to is not rounded and taken straight from event.data.$element.parent().outerHeight().
For instance: if the window height is 946px and the height is set to 75%, adjustedValue will be 709px, but event.data.$element.parent().outerHeight() will be 708.984px, which will cause the evaluation to determine it is smaller than adjustedValue, resulting in the height being set to "auto", and then back to a fixed value which repeats the cycle.
I haven't tested this on 11.x yet, but since the code is the same there, I imagine it might also cause issues under certain circumstances.
I noticed there are efforts to ditch jQuery UI dialog altogether, but I wanted to create this issue regardless, so people running into the same issue have some way to resolve it without being forced to wait for the new dialog implementation to drop.
- Use an admin theme where the dialog title bar has a height with a subpixel value (like Gin, or zoom out 1 step with Claro).
- Open a dialog window whose size is set to a percentage value (in core it's the media library modal).
- Tigger the window resize handler multiple times and notice how the height value on #drupal-modal toggles between "auto" and a numerical pixel value.
(Tested on Chrome)
Round the height of the dialog before comparing it to the already rounded adjustedValue.
Create MR adding Math.round around event.data.$element.parent().outerHeight().
Review.
n/a
n/a
n/a
Fixed
10.4 ✨
Fix in the previous 10.3.x branch was correct, ported to 11.x
Committed and pushed 9d6c9f788c to 11.x and 37f50d6d49 to 10.4.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.