Fatal error: Declaration of AzBlobFsImageStyleDownloadController must be compatible with ImageStyleDownloadController

Here is the patch

I just bumped into this issue when upgrading to 10.3, thank you for the patch.

I'm now getting the following exception:

RuntimeException: Controller "Drupal\az_blob_fs\Controller\AzBlobFsImageStyleDownloadController::deliver" requires that you provide a value for the "$required_derivative_scheme" argument. Either the argument is nullable and no null value has been provided, no default value has been provided or there is a non-optional argument after this one. in Symfony\Component\HttpKernel\Controller\ArgumentResolver->getArguments() (line 110 of /opt/drupal/vendor/symfony/http-kernel/Controller/ArgumentResolver.php).

I imagine there are places where AzBlobFsImageStyleDownloadController::deliver gets called without providing the $required_derivative_scheme.

I'm not familiar enough with the module and the changes introduced by 10.3 but will try to give this a go when I get a bit of free time.

Just a stopgap patch to avoid RuntimeException while $required_derivative_scheme can be fully implemented.

I have just noticed your issue in my project. Seems we are using your patch, and I just created a new issue fixing the last warning :

https://www.drupal.org/project/az_blob_fs/issues/3460622 🐛 ImageStyleDownloadController::deliver() now takes a string of the expected scheme for derivatives as a required parameter Active

This patch fix both

Test #11 works

Confirming #11 🐛 Fatal error: Declaration of AzBlobFsImageStyleDownloadController must be compatible with ImageStyleDownloadController Active works as expected. Ready for release.

Thank you for merging this. However, in the future, let's please:

• Mark fixed issues as fixed. (I saw an MR here, but there was nothing to indicate that it was merged.)
• In the commit title (or MR title if you're squashing), refer to the issue so we know what issues went into the branch with "Issue #3457065: ..."

Both of these are in the Commit Process → . Please review it.

I spend some time trying to figure out why the patch wouldn't apply, unnecessarily. The above would have avoided that.

Automatically closed - issue fixed for 2 weeks with no activity.