- Issue created by @mindaugasd
- π©πͺGermany marcus_johansson
The most important reason is that a production ready version is probably around Drupal 11 release, so 10.3 will have been around for some time.
But its also so we don't have to support annotations at all. Its already built around attributes which makes it easier to understand.
- Status changed to Closed: works as designed
10 months ago 1:54pm 20 June 2024 - π±πΉLithuania mindaugasd
I found in multiple sources release date of 10.3 is June 17, so already past the deadline and should be released shortly.
While Drupal 11 will be later (by some sources even maybe December, or maybe July).
I am marking as closed, because release should be soon and because of attributes.
- Status changed to Active
9 months ago 6:53pm 8 July 2024 - π±πΉLithuania mindaugasd
I am reopening the issue, because according to this page https://www.drupal.org/docs/drupal-apis/plugin-api/attribute-based-plugins β Drupal 10.2 also supports attributes.
I no longer need this myself, but there was another question on slack. - π©πͺGermany marcus_johansson
If anyone would take the time to test it on Drupal 10.2 and can confirm it works, then we can lower the requirements.
- Assigned to marcus_johansson
-
Marcus_Johansson β
committed ce77429e on drupal10.2-php81
Issue #3455954 by Marcus_Johansson: Reduce drupal core requirement from...
-
Marcus_Johansson β
committed ce77429e on drupal10.2-php81
- π©πͺGermany marcus_johansson
There is a pull request for this here: https://git.drupalcode.org/project/ai/-/merge_requests/39
All modules will work with 10.2, except the AI CKEditor that will require 10.3 because of CKEditor updates in this update.
This also removes a dependency on PHP 8.2+ from the Milvus library. I wrote our own and it will work with PHP 8.1.
- Status changed to Needs review
8 months ago 3:48pm 6 August 2024 - Status changed to Fixed
8 months ago 6:33pm 13 August 2024 - π©πͺGermany marcus_johansson
This has been merge with 1.0.x-dev. The initial tests shows that everything works, except CKEditor 10.3.
- πΊπΈUnited States kevinquillen
I don't see the above really being a problem (CKEditor).
Automatically closed - issue fixed for 2 weeks with no activity.
- π³π±Netherlands ronaldtebrake
Just thought I'd circle back here;
I've just tested ai_ckeditor on Drupal 10.2 it seems the only change that really breaks is the fact we useViewModel
in
https://git.drupalcode.org/project/ai/-/blob/1.0.x/modules/ai_ckeditor/j...Where for Drupal 10.2 and the version of CKEditor 5 shipped in there it's still
Model
instead ofViewModel
.As per:
https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-41....We renamed the export of Model from the @ckeditor/ckeditor5-ui package to ViewModel.
Changing that makes it work nicely on Drupal 10.2, but can imagine that's not necessarily something you'd want to support.