Remove commented-out code in ArgumentDefaultTest referring to php module

Created on 18 June 2024, 12 days ago
Updated 19 June 2024, 11 days ago

Problem/Motivation

\Drupal\Tests\views\Functional\Plugin\ArgumentDefaultTest has the following commented-out code:

  /**                                                                           
   * @todo Test php default argument.                                           
   */
  // function testArgumentDefaultPhp() {}   

There are two possible ways to address this:

  1. Figure out what is not tested and needs to be, file a proper followup for it, remove the commented-out code, and add a @todo to the class docblock.
  2. Or, if the suggestion is out of date or we can't determine its intent, just remove the dead code with no followup.

Proposed resolution

Remove the commented out code. It is which only a function name, a placeholder for tests with the php module installed to be added later.

Remaining tasks

Review

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

πŸ“Œ Task
Status

Fixed

Version

10.3 ✨

Component
ViewsΒ  β†’

Last updated 24 minutes ago

Created by

πŸ‡ΊπŸ‡ΈUnited States xjm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024