Contrib.social

Automated Drupal 11 compatibility fixes for views_remote_data

Open on Drupal.org →
Created on 18 June 2024, 10 days ago
Updated 25 June 2024, 2 days ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Project Update Bot
  • Comment 10 days ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Merge request !18Automated Project Update Bot fixes → (Open) created by Project Update Bot
  • Pipeline finished with Success
    10 days ago
    Total: 180s
    #201656
  • Merge request !19Issue #3455320: Make D11 ready. → (Merged) created by ankitv18
  • First commit to issue fork.
  • Pipeline finished with Canceled
    10 days ago
    Total: 53s
    #201961
  • Pipeline finished with Success
    10 days ago
    Total: 155s
    #201962
  • Pipeline finished with Success
    10 days ago
    Total: 246s
    #201973
  • Comment 10 days ago →
    🇮🇳India ankitv18

    ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

  • Pipeline finished with Success
    10 days ago
    Total: 184s
    #201978
  • Status changed to Needs work 3 days ago
  • Comment 3 days ago →
    🇺🇸United States mglaman WI, USA

    There are a lot of changes in this MR which didn't need to happen.

    What is the breaking change? It looks like one or two test generator methods needed to be made static, correct? The MR you hid is far simpler and more succinct in changes needed: https://git.drupalcode.org/project/views_remote_data/-/merge_requests/18...

  • Comment 3 days ago →
    🇮🇳India ankitv18
  • Pipeline finished with Canceled
    3 days ago
    Total: 217s
    #207383
  • Pipeline finished with Failed
    3 days ago
    Total: 1115s
    #207387
  • Pipeline finished with Success
    3 days ago
    Total: 430s
    #207407
  • Pipeline finished with Success
    3 days ago
    Total: 155s
    #207412
  • Pipeline finished with Success
    3 days ago
    Total: 229s
    #207423
  • Pipeline finished with Success
    3 days ago
    Total: 225s
    #207428
  • Status changed to Needs review 3 days ago
  • Comment 3 days ago →
    🇮🇳India ankitv18

    @mglaman Bot MR is not fixing every thing, apart from Bot fix there are few changes which is required for D11.
    For some reasons phpunit next major pipeline isn't running https://git.drupalcode.org/issue/views_remote_data-3455320/-/jobs/194621...

    anyways I have reverted the phpcs changes and info.yml changes, also removed cspell words pipeline fix.

  • Status changed to Needs work 3 days ago
  • Comment 3 days ago →
    🇺🇸United States japerry KVUO

    Ahh it looks like drupalci is grepping for the major version in the info file.. thats unfortunate. This needs fixing: https://www.drupal.org/project/gitlab_templates/issues/3456092 →

  • Comment 3 days ago →
    🇮🇳India ankitv18

    Thanks @japerry updated the info.yml with ^9 || ^10 || ^11
    cc: @mglaman

  • Status changed to Needs review 3 days ago
  • Comment 3 days ago →
    🇮🇳India ankitv18
  • Pipeline finished with Success
    3 days ago
    Total: 217s
    #207524
  • Comment 2 days ago →
    🇺🇸United States mglaman WI, USA

    Thanks for tidying up the MR.

  • Pipeline finished with Skipped
    2 days ago
    #208076
  • Comment 2 days ago →
    System Message
  • Status changed to Fixed 2 days ago
  • Comment 2 days ago →
    🇺🇸United States mglaman WI, USA

    Merged, tagging a release.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024