- Issue created by @kim.pepper
- Merge request !8438#3455183 FileSaveUploadTest should not write to the app root โ (Closed) created by kim.pepper
- Status changed to Needs review
about 1 year ago 11:30pm 17 June 2024 - Status changed to Needs work
about 1 year ago 11:33pm 17 June 2024 - ๐ฆ๐บAustralia mstrelan
This was also spotted in ๐ PHPUnit 10 behaves differently when invoked outside web root Needs review and I added a tearDown method to remove the created file. We can remove that tearDown method now in this issue.
- Status changed to Needs review
about 1 year ago 11:33pm 17 June 2024 - Status changed to RTBC
about 1 year ago 1:53pm 18 June 2024 - ๐ฎ๐นItaly mondrake ๐ฎ๐น
Itโs a Kernel test, why not using vfs instead?
- Status changed to Downport
about 1 year ago 3:17pm 19 June 2024 - ๐บ๐ธUnited States xjm
Definitely much better.
Committed to 11.x and 11.0.x. There's a merge conflict on cherry-pick to 10.4.x, so we would need a different backport version.
Thanks!
- First commit to issue fork.
- Merge request !9371Issue #3443748: : FileSaveUploadTest should not write to the app root. โ (Closed) created by pooja_sharma
-
alexpott โ
committed 8ee22c46 on 10.5.x
Issue #3455183 by kim.pepper, mstrelan, xjm, mondrake:...
-
alexpott โ
committed 8ee22c46 on 10.5.x
-
alexpott โ
committed 76c2d39a on 10.6.x
Issue #3455183 by kim.pepper, mstrelan, xjm, mondrake:...
-
alexpott โ
committed 76c2d39a on 10.6.x
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Seems fair enough to backport to 10.5.x.
Committed and pushed 76c2d39afb4 to 10.6.x and 8ee22c46ac4 to 10.5.x. Thanks!
I think this is a bug. Tests should not leave files around.
Automatically closed - issue fixed for 2 weeks with no activity.