[2.0.0-alpha3] Refactoring of form elements

Open on Drupal.org →

Created on 17 June 2024, 5 months ago

Updated 1 July 2024, 5 months ago

Problem/Motivation

The actual situation in terms of "FormElement" in the ui_patterns 2.0.x code :
- component_form : build component selector form, and component form. The component form triggers component_props_form and component_slots_form, passing data (contexts..etc)
- component_props_form, build a complex form, one complex form per prop of the selected component. sources are fetched according to prop type and contexts
- component_slots_form : build a complex form, one complex form per slot of the selected component sources are fetched according to prop type and contexts

Some issues :
- The way we deal with sources can be improved, especially that now we have "tags" in sources, and the source plugin manager supports tag_filtering.
- In others issues #3423185 ✨ [2.0.0-alpha3] Add allow_expose source plugin Active & #3444768 ✨ [2.0.0-alpha3] Blocks: Add sources with an entity context Needs review , we may need to re-use a source selector, but the current implementation is oriented toward the form of a whole component, and do not really split nicely the implementation of each prop and slot, which are mixed into the component_props_form and component_slots_form elements.
- The way we handle ajax is a bit tricky, because we play with array_parents. We may need to enforce the way it is done to ensure implement keeps nice and robust.

Steps to reproduce

Proposed resolution

We refactor the form elements to have component_prop_form and component_slot_form (or a generic one for both?) :
we explicitly add new arguments like : tags, form_array_parents..etc
Note that the tags are used to fetch the sources accordingly.
form_array_parents is used to properly interact with form state and ajax.

The new code should allow reusing of component_prop_form or component_slot_form in a source plugin for example...

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task

Status

Fixed

Version

2.0

Component

Code

Created by

🇫🇷France just_like_good_vibes PARIS

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!117[2.0.0-alpha3] Refactoring of form elements
Merged
🇩🇪Germany Christian.wiedemann
updated 5 months ago

Comments & Activities

Issue created by @just_like_good_vibes
Comment 5 months ago →
🇩🇪Germany Christian.wiedemann
Christian.wiedemann → made their first commit to this issue’s fork.
Merge request !117Resolve #3455074 "2.0.0 alpha3 refactoring of" → (Merged) created by Christian.wiedemann
Status changed to Needs review 5 months ago3:21pm 17 June 2024
Comment 5 months ago →
🇩🇪Germany Christian.wiedemann
Hopefully the last refactor of the component form element.

Following stuff improved:
- Add Slot and Prop Component to render a single slot or prop for a given component.
- Add consistent documentation
- Clean argument mess inside the functions. Every function: ($element, $form_state, $definition, ?$wrapper_id)
Each methods takes sources_context etc. from the element array.
- Streamline ajax handling. No counting etc. You can put every component class in any form and ajax works.
Comment 5 months ago →
System Message

Christian.wiedemann → committed 51cdafbe on 2.0.x
Issue #3455074 by Christian.wiedemann: [2.0.0-alpha3] Refactoring of...
Status changed to Fixed 5 months ago7:49pm 17 June 2024
Comment 5 months ago →
🇩🇪Germany Christian.wiedemann
Comment 5 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024