[2.0.0-alpha3] Blocks: Add sources with an entity context

Entity Field Source Plugin (for slots): Pick and configure a block from all field specific to the entity related to the display we are currently editing. Form : select the field, a formatter and configure the formatter.

This look like a generalization of the FieldFormatter source from ui_pattrns_field_formatters where the context is the (entity type, field) tuple (we cannot select something outside of the field we are currently working on):, and the configuration is the selected formatter configuration form

An other issue is dealing with the generalization of an ui_pattrns_field_formatters source plugin: ✨ [2.0.0-alpha3] Add allow_expose source plugin Active

i take this one :)

This can easily done with the refactoring of the forms. We can use slot form widget inside a block and we are done. Should I take it?

An we exchanged during the weekly, let's remark the following thing in the current 2.0.x codebase.
when we treated the issue 3444716 ✨ [2.0.0-alpha3] Add block source (for slots) Fixed ,
we declared a new consumer "ui_patterns" for block discovery and filtering.
As seen in Drupal\ui_patterns\Plugin\UiPatterns\Source::listBlockDefinitions,
we are calling plugin.manager.block:getFilteredDefinitions with ui_patterns as the first argument.
(see Drupal\Core\Plugin\FilteredPluginManagerTrait::getFilteredDefinitions).
this implies, some alter hooks are called during plugin discovery "plugin_filter_{$type}" and "plugin_filter_{$type}__{$consumer}".

We proposed a first implementation of those hooks in ui_patterns.module, and this may not be perfect right now,
and has to refined maybe in this issue.

see functions "ui_patterns_plugin_filter_block__ui_patterns_alter" and "ui_patterns_plugin_filter_block_alter" in ui_patterns.module

thanks christian, to parallelize last alpha3 efforts, i re-take it :)

Entity Link Label Source Plugin (for strings): Select the entity link among $entity_type->getLinkTemplates()

Removed from scope

ready for review

I will have a look

Hello,
what a mess...

To summarize :
- playing with contexts, i found several bugs in our implementation, which i corrected.
- i refactored a little bit how injection was done with source plugins, was quite strange. some source plugin constructors have thus changed
- i added some services to source plugin base
- LB field blocks are quite singular, but they are available
- entity link urls are available

Main drawback :
the current implementation does not allow some scenarios in Layout Builder.
Especially, we have quite a problem when we use "ComponentBlock" Block plugin, because at rendering they can't get the real entity renderer from the context. thus, the entity cannot be passed to source plugins. so as soon as there is a ComponentBlock in LB, any source which needs in its context the entity being rendered by LB won't work.
to allow "ComponentBlock" block plugins to "receive" in their contexts the LB entity rendered, we need an "entity" content definition for the block plugin plus a context_mapping from layout_builder.entity. And it is difficult to do that, because those two things are not always needed, or it would break "ComponentBlock" blocks from rendering if they are rendered elsewhere without any entity...
very difficult problem. still WIP for me.
maybe we can merge this implementation and postpone this very special case of LB + ComponentBlock entity contexts?

and also... when testing, be careful with an existing site configuration.

when you install layout_builder now, it will automatically enables "layout_builder_expose_all_field_blocks" sub-module.
please be sure to have a fresh installs, run "drush updb" or manually check this submodule is enabled.
it is required to allow LB field blocks to show in UI patterns block selection.

KO

Formatter in Manage display:

• Block with context? (without expose_all_field_blocks module) >> Not in selector
• Entity link? >> OK

Block in Layout Builder

• Block with context? (without expose_all_field_blocks module) >> Visible in selector, but "Uncaught PHP Exception LogicException: "TODO: entity is missing from the context" at src/Plugin/UiPatterns/Source/BlockSource.php line 257"
• Entity link? >> Visible in selector, but "count(): Argument #1 ($value) must be of type Countable|array, null given" at src/Element/ComponentElementBuilder.php

Formatter in Layout Builder:

• Block with context? (without expose_all_field_blocks module) >> Visible in selector, but silent error when I chose a formatter for the embeded field block: the component form is reinitializing
• Entity link? >> OK

Also, I have this issue when I chose a link which is not allowed:
Uncaught PHP Exception Symfony\Component\Routing\Exception\RouteNotFoundException: "Route "entity.node.create" does not exist." at /core/lib/Drupal/Core/Routing/RouteProvider.php line 208"

i have pushed somes updates :

In UI Patterns Blocks
- now we have two families of block plugins :
- the ones that are specific for layout builder, should not appear anywhere else. They have a context_definitions with an entity and a context_mapping for layout builder.
- the ones that are used elsewhere (block layout page, in the select list of block source plugin..), they should not appear in layout builder.

- playing with contexts, i found bugs in our implementations, which i corrected. See for example 3 lines removed in SourcePluginBase class.
also the function getComponentSourceContexts in field formatters (see ComponentFormatterBase, ComponentPerItemFormatter, ComponentFormatter.php
- i refactored a little bit how injection was done with source plugins, its was quite strange (i added some services to source plugin base). Some source plugin constructors have thus changed. it has trigger changes in sources from UI patterns and UI patterns field formatters : FieldFormatterSource, BlockSource, BreadcrumbSource, FieldPropertySourceBase, FieldSourceBase,

- some blocks provided by layout builder are not appearing in the "Block source" select list : the blocks that have required contexts (in context_definitions) other than "entity". see ui_patterns.module changes

Rebased and ready ;)

changes component to "code", as it also includes some changes in the main module and in the field formatters module

I will have a look

unfortunately,context mapping and reloading mapped entity does not work good in Layout builder.
for example, add a ui patterns block in LB, in a slot or a prop, use the source Entity link URL.
the block has a bonus select at the bottom, to select the mapped entity.
the loading/reloading does not working well yet.

i need to correct a few things.. you can still review it in its actual state.

ok, i pushed many fixes. should be really better