- Issue created by @tim-diels
- last update
10 months ago 21 pass - Issue was unassigned.
- Status changed to Needs review
10 months ago 3:00pm 11 June 2024 - 🇧🇪Belgium tim-diels Belgium 🇧🇪
I've provided a start to support for Time
But not sure how to add the correct constraints in the TimeType... So will need help there.
See https://git.drupalcode.org/project/time_field/-/merge_requests/16/diffs#...If this is a good proposal, we can implement this for TimeRangeType also.
There is some duplicate code that can be substracted to a service or helper class. This can be discussed.
- last update
10 months ago 21 pass - last update
10 months ago 21 pass - last update
10 months ago 21 pass - Status changed to Needs work
10 months ago 3:35pm 12 June 2024 - 🇧🇪Belgium BramDriesen Belgium 🇧🇪
I have no objections for adding this :-) setting back for the other widget and the todo in the code.
- First commit to issue fork.
- 🇧🇪Belgium andreasderijcke Antwerpen / Gent
- The empty value (86401) was missing. I've introduced a static function to check for this.
- Constraint check added too.
- Rebase with current 2.x
There more potential for reuse of code parts.
Also, the empty value 86401 appears both as int and string across the module. I recommend streamlining this.