- Issue created by @dww
- Merge request !8337[#3453318] task(views): Remove deprecation about Views argument config conversion in 10.3.x โ (Open) created by dww
- Status changed to Needs review
8 months ago 9:30pm 7 June 2024 - Status changed to RTBC
7 months ago 5:44pm 9 June 2024 - ๐บ๐ธUnited States smustgrave
Thanks for the detailed right up.
Change looks straightforward and didn't break anything so don't mind marking.
- Status changed to Needs review
7 months ago 10:06am 10 June 2024 - ๐ฌ๐งUnited Kingdom catch
Per the slack thread this needs more discussion still.
- ๐บ๐ธUnited States dww
Iโm okay to keep discussing, but 10.3.0-rc1 is out, so we have very little time to get this done if itโs going to matter at all. ๐
To me, it boils down to the costs of leaving it in (hardship for maintainers that like to โchase HEADโ) vs the costs of removing it (none, other than the time to discuss it). ๐
The primary argument from Berdir against this is basically โchasing HEAD is a fruitless, pointless effort that only leads to more work and sufferingโ. I pretty much agree with that, and donโt do it myself. ๐ But some maintainers like to do it, anyway, and by one perspective, theyโre trying to do the right thing by staying on top of core development that impacts their code.
As I wrote in the summary, the perspective I do hold is that, when feasible (or in this case, trivial) to make it easier for contrib to put out releases that are as widely compatible as possible, we should.
Not sure who else needs to chime in before a decision is made. I only hope it happens soon. ๐
Thanks,
-Derek - ๐บ๐ธUnited States smustgrave
based on what I've seen on majority of contrib modules most maintainers aren't doing that haha. Some of them just jump in every few months sometimes, which is fine. So whatever can be done to help them out +1 from me.
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
Maybe we can use the SYMFONY_DEPRECATIONS_HELPER variable to ignore that specific deprecation or set it to some value that allows the test to pass. See https://symfony.com/doc/current/components/phpunit_bridge.html#making-te...
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
I'm not sure we should not be making this change. We should make our tooling support this. I tend to disable deprecation reporting in CI use deprecation reporting when I run the tests locally or when Iโm prepping to change update the minimum supported version.
Given we have the drupal version in the deprecation message we should extend SYMFONY_DEPRECATIONS_HELPER to take a value like drupal-verion=10.2.x and then skip deprecations from 10.3.x and above.
- ๐ฌ๐งUnited Kingdom catch
Yeah I agree it's a real problem but to do this all the time we'd end up needing three MRs for every similar issue (Drupal 11, no deprecation or bc layer, Drupal 10.4 deprecation + bc layer, Drupal 10.3, bc layer and no deprecation).
Linking #3225792: Allow core deprecation testing to distinguish between major versions โ , also wondering if we should move this to gitlab templates or open a new issue there? It would be nifty to be able to do this generically.
- ๐บ๐ธUnited States smustgrave
Since this seems to be like something that needs to land in 10.3 or not be needed could we move forward here and open a follow up for more discussion?
- Status changed to Closed: duplicate
7 months ago 7:51pm 13 June 2024 - ๐ฌ๐งUnited Kingdom catch
I think we should continue in #3225792: Allow core deprecation testing to distinguish between major versions โ , going to retitle that one, closing this as duplicate.