- Issue created by @phenaproxima
- πΊπΈUnited States phenaproxima Massachusetts
Since this could have a major performance impact, I'm bumping it.
- Merge request !511Remove plugin ID caching in ProjectBrowserEndpointController β (Merged) created by phenaproxima
- Status changed to Needs review
11 days ago 2:13pm 17 June 2024 - π¦πΊAustralia sime Canberra
If I'm reading the code correctly, every unique
$SOURCE_PLUGIN_ID/$SOME_LOCAL_ID
gets a separate key set? If this numbered into the thousands or tens of thousands I don't this kv is the best place, especially being the place I most associate with Redis, and these IDs are not values I assocaited with require super fast runtime read/write. Would it be better to use a cache bin? - πΊπΈUnited States phenaproxima Massachusetts
@sime, the problem with a cache bin is that it can be wiped out at any time, and since this data has to persist across multiple requests, we need to guarantee that it can't just disappear because some other user did a cache clear while you were trying to install something. So I needed something "stickier", thus the key-value store.
- π¦πΊAustralia sime Canberra
And it would be so easy to swap KV with something else if needed later.
Everything else makes sense and it's worth a maintainer having a look - the key thing I see is changes to how the projects are uniquely identified and then all the services are adjusted to support that.
- πΊπΈUnited States chrisfromredfin Portland, Maine
tim.plunkett β credited chrisfromredfin β .
- Status changed to RTBC
8 days ago 3:07pm 20 June 2024 -
tim.plunkett β
committed 7dabf877 on 2.0.x authored by
phenaproxima β
Issue #3452787 by phenaproxima, tim.plunkett, sime, chrisfromredfin:...
-
tim.plunkett β
committed 7dabf877 on 2.0.x authored by
phenaproxima β
- Status changed to Fixed
8 days ago 3:08pm 20 June 2024