Make it possible for Project Browser to activate different kinds of projects

Created on 15 May 2024, 6 months ago
Updated 20 June 2024, 5 months ago

Problem/Motivation

Project Browser was built for MVP with the assumption that it would only need to handle modules, although ultimately we knew it would someday possibly handle at least themes, maybe recipes... maybe other things later.

Right now, Project Browser can install only one kind of thing: modules. Themes are not handled by it, nor recipes, or any other kind of package. We need to be able to see, for example, a list of themes, and be able to click an "Install" button which downloads and enables that theme. That's not currently possible.

Proposed resolution

Introduce the idea of an "Activator," which will abstract and handle the enabling of whatever type of Project there is - be it a installing module, applying a recipe, enabling a theme, etc.

โœจ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
  • Starshot blocker

    A potential blocker for Drupal Starshot. More information: http://www.drupal.org/project/starshot

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !483Resolve #3447377 "Make it possible" โ†’ (Merged) created by phenaproxima
  • Pipeline finished with Failed
    6 months ago
    Total: 344s
    #173432
  • Pipeline finished with Failed
    6 months ago
    Total: 363s
    #173439
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

    Looking at this Draft MR today with @phenaproxima - https://drupal.slack.com/archives/C01UHB4QG12/p1715785363763219

    This feels like the right general approach to me, we need to abstract 'activation' from assumptions about project type so that we can support more things. This is how I would have approached it, also.

    General considerations are namespace collisions - but sounds like using Project (which already knows its type) will handle, for example, a recipe named 'zen' and a module named 'zen' - should such a thing exist.

    This gives a good separation of concerns, also, that Projects can be meta/global information about a project from the source, and Activators can store more site-specific information relative to this Project - i.e. "installed status" for a Project.

  • Pipeline finished with Failed
    6 months ago
    Total: 510s
    #173480
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia sime Melbourne

    Is it possible to have a story in the OP? I kinda follow but it's easy to misinterpret stuff for those coming in blind since DrupalCon.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine
  • Status changed to Postponed 6 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts
  • ๐Ÿ‡ญ๐Ÿ‡บHungary Gรกbor Hojtsy Hungary
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia prashant.c Dharamshala

    I was searching for themes when I stumbled upon this issue. I'm really hoping it will support themes, which would be a fantastic bonus.

    Thanks!

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    Theme support isn't going to be added by this issue, but this will lay some of the groundwork needed in order to support themes. :)

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia prashant.c Dharamshala

    @phenaproxima

    Yes, I agree. :)

  • Status changed to Needs work 6 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    Blocker's in!

  • Pipeline finished with Failed
    6 months ago
    Total: 229s
    #190937
  • Pipeline finished with Canceled
    6 months ago
    Total: 132s
    #190940
  • Pipeline finished with Failed
    6 months ago
    Total: 312s
    #190947
  • Pipeline finished with Canceled
    6 months ago
    #190950
  • Pipeline finished with Failed
    6 months ago
    Total: 362s
    #190951
  • Pipeline finished with Failed
    6 months ago
    Total: 355s
    #190958
  • Pipeline finished with Canceled
    6 months ago
    Total: 243s
    #190970
  • Pipeline finished with Failed
    6 months ago
    #190976
  • Pipeline finished with Failed
    6 months ago
    Total: 463s
    #191850
  • Pipeline finished with Failed
    6 months ago
    Total: 360s
    #191855
  • Pipeline finished with Canceled
    6 months ago
    Total: 193s
    #191867
  • Pipeline finished with Failed
    6 months ago
    Total: 456s
    #191870
  • Pipeline finished with Success
    6 months ago
    #191880
  • Pipeline finished with Success
    6 months ago
    Total: 394s
    #191886
  • Issue was unassigned.
  • Status changed to Needs review 6 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts
  • Pipeline finished with Failed
    6 months ago
    Total: 366s
    #192006
  • Pipeline finished with Failed
    6 months ago
    Total: 226s
    #192033
  • Pipeline finished with Failed
    6 months ago
    Total: 1936s
    #192012
  • Pipeline finished with Failed
    6 months ago
    Total: 357s
    #192038
  • Pipeline finished with Failed
    6 months ago
    Total: 363s
    #192043
  • Pipeline finished with Failed
    6 months ago
    Total: 569s
    #192052
  • Pipeline finished with Success
    6 months ago
    Total: 382s
    #192079
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    Manually tested this on my local machine, by the way, and it worked flawlessly.

  • Pipeline finished with Success
    6 months ago
    #192255
  • Pipeline finished with Skipped
    6 months ago
    #192262
  • Status changed to Fixed 6 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States bnjmnm Ann Arbor, MI
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States chrisfromredfin Portland, Maine

    One giant leap for mankind...

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024