- Issue created by @david.qdoscc
- 🇨🇭Switzerland saschaeggi Zurich
Hey 👋
We discovered a bug in combination with the Gin Admin Theme as it renders a duplicated table header as of which the
module_filter.permisisons.js
changes the filter's location.Is there any reason we need line 21 of that JS file?
It seems to just run fine without moving location and has the benefit of the layout not shifting as well.
So I'd propose we either:
- Remove line 21$(wrapperId).parent().prepend($input.closest('.table-filter'));
- Add a check if Gin is installed and do not execute line 21 - Merge request !50Resolve #3452725 "Fix permissions table header gin 5x" → (Closed) created by saschaeggi
- Merge request !51Resolve #3452725 "Fix permissions table header gin 5x" → (Closed) created by saschaeggi
- Status changed to Needs review
6 months ago 3:34pm 5 June 2024 - 🇨🇭Switzerland saschaeggi Zurich
I've created a MR again both
4.x
&5.x
Needs a review
-
smustgrave →
committed 04d58f27 on 5.x
Issue #3452725 by saschaeggi, david.qdoscc: Permissions table header is...
-
smustgrave →
committed 04d58f27 on 5.x
-
smustgrave →
committed 08dc6531 on 4.x
Issue #3452725 by saschaeggi, david.qdoscc: Permissions table header is...
-
smustgrave →
committed 08dc6531 on 4.x
- Status changed to Fixed
5 months ago 2:19pm 17 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.