NodeListBuilder is using mark theme wrongly

Created on 4 June 2024, 21 days ago
Updated 20 June 2024, 5 days ago

Problem/Motivation

In https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/node/...

public function buildRow(EntityInterface $entity) {
    /** @var \Drupal\node\NodeInterface $entity */
    $mark = [
      '#theme' => 'mark',
      '#mark_type' => node_mark($entity->id(), $entity->getChangedTime()),
    ];

While the mark theme key is defined in https://git.drupalcode.org/project/drupal/-/blob/11.x/core/includes/them...

'mark' => [
      'variables' => ['status' => MARK_NEW],
    ],

So it is using the mark key with a wrong variable. But, it is working... and I have not found in core any other 'mark_type' occurrence.

Steps to reproduce

Disable the admin content view.

Proposed resolution

Use status.

Remaining tasks

- propose MR
- review

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

πŸ› Bug report
Status

Needs review

Version

11.0 πŸ”₯

Component
Node systemΒ  β†’

Last updated about 8 hours ago

No maintainer
Created by

πŸ‡«πŸ‡·France Grimreaper France πŸ‡«πŸ‡·

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024