- Issue created by @Grimreaper
- Merge request !8286Issue #3452502 by Grimreaper: NodeListBuilder is using mark theme wrongly β (Open) created by Grimreaper
- Issue was unassigned.
- Status changed to Needs review
21 days ago 3:40pm 4 June 2024 - Status changed to Needs work
21 days ago 5:11pm 4 June 2024 - πΊπΈUnited States smustgrave
Can the MR be updated for 11.x vs 11.0.x please
- Assigned to Grimreaper
- Merge request !8295Issue #3452502 by Grimreaper: NodeListBuilder is using mark theme wrongly β (Open) created by Grimreaper
- Issue was unassigned.
- Status changed to Needs review
21 days ago 8:24am 5 June 2024 - π«π·France Grimreaper France π«π·
@smustgrave, I opened a new MR against 11.x.
- πΊπΈUnited States smustgrave
smustgrave β changed the visibility of the branch 3452502-nodelistbuilder-is-using to hidden.
- Status changed to RTBC
20 days ago 2:17pm 5 June 2024 - πΊπΈUnited States smustgrave
Before
After
Can confirm the issue and that the MR seems to fix it. Change seems small enough that tests seem overkill.
- π«π·France Grimreaper France π«π·
@smustgrave, thanks for testing and RTBC.
Have you inverted the before/after screenshots? Because it seems strange that the "New" is not displayed after.
- πΊπΈUnited States smustgrave
That was the only difference I saw on the page after applying the MR.
- π«π·France Grimreaper France π«π·
Ok, Have you clicked/viewed the "Article 1" node from your screenshots between the 2 screenshots?
In my case, on core 10.2, I don't see any differences after applying the patch which, like I mentioned in the original report, is "normal" because it should fix it.
What I don't understand is, why it works without the patch.
- Status changed to Needs review
20 days ago 3:52pm 5 June 2024 - πΊπΈUnited States smustgrave
Not sure, will put back to NR for further digging
- πΊπΈUnited States smustgrave
So retested again
1. Disabled Content view
2. went to /admin/contentwithout the MR I see the "New" next to the title
With the MR I don't - Status changed to Needs work
13 days ago 2:50pm 12 June 2024 - πΊπΈUnited States smustgrave
@Grimreaper since we are seeing different things can you post maybe some screenshots of what you're seeing?
- Status changed to Needs review
13 days ago 3:10pm 12 June 2024 - π«π·France Grimreaper France π«π·
@smustgrave, no problem. I have not uploaded before because there was no difference:
Before patch:
After patch:
- πΊπΈUnited States smustgrave
Sorry for the delay so with the MR what is fixed for you?
- π«π·France Grimreaper France π«π·
No worries,
As written in the issue summary, there is something that should not work which actually work and the MR "fix" how the "mark" theme key should be used.