NodeListBuilder is using mark theme wrongly

Can the MR be updated for 11.x vs 11.0.x please

@smustgrave, I opened a new MR against 11.x.

smustgrave → changed the visibility of the branch 3452502-nodelistbuilder-is-using to hidden.

Before

After

Can confirm the issue and that the MR seems to fix it. Change seems small enough that tests seem overkill.

@smustgrave, thanks for testing and RTBC.

Have you inverted the before/after screenshots? Because it seems strange that the "New" is not displayed after.

That was the only difference I saw on the page after applying the MR.

Ok, Have you clicked/viewed the "Article 1" node from your screenshots between the 2 screenshots?

In my case, on core 10.2, I don't see any differences after applying the patch which, like I mentioned in the original report, is "normal" because it should fix it.

What I don't understand is, why it works without the patch.

Not sure, will put back to NR for further digging

So retested again

1. Disabled Content view
2. went to /admin/content

without the MR I see the "New" next to the title
With the MR I don't

@Grimreaper since we are seeing different things can you post maybe some screenshots of what you're seeing?

@smustgrave, no problem. I have not uploaded before because there was no difference:

Before patch:

After patch:

Sorry for the delay so with the MR what is fixed for you?

No worries,

As written in the issue summary, there is something that should not work which actually work and the MR "fix" how the "mark" theme key should be used.

Think I had something cached because coming back I'm getting the same results now. Seems like a small enough change that test coverage probably isn't needed since it's working, just don't know why haha.

#2021161: Replace the fallback node listing with a list controller → incorrectly replaced status with mark_type... because #2010672: Rename 'type' variable of theme_mark to 'status' → had happened while it was being developed and obviously a re-roll was not careful enough.

Committed and pushed 32a59501a9 to 11.x and fe34d77335 to 11.0.x and 62d49255b9 to 10.4.x and fdb36c43ab to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.