Twitter logo needs to updated

Created on 3 June 2024, 7 months ago
Updated 5 June 2024, 7 months ago

Problem/Motivation

The twitter logo needs to be updated.

Steps to reproduce

1. Install the module, configure as per your need.
2. Make sure you select the twitter service.
3. Place the widget as a block or attach it with the preferred content type.
4. You'll see that the twitter logo is still the old one.

Proposed resolution

The icon needs to be updated with the new Twitter logo X

🐛 Bug report
Status

Needs review

Version

3.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
  • Needs subsystem maintainer review

    It is used to alert the maintainer(s) of a particular core subsystem that an issue significantly impacts their subsystem, and their signoff is needed (see the governance policy draft for more information). Also, if you use this tag, make sure the issue component is set to the correct subsystem. If an issue significantly impacts more than one subsystem, use needs framework manager review instead.

Sign in to follow issues

Comments & Activities

  • Issue created by @sourojeetpaul
  • Assigned to Muskan0215
  • Issue was unassigned.
  • Assigned to sourojeetpaul
  • Issue was unassigned.
  • I took a deeper dive onto the issue of the twitter logo of this module! But as all the CSS and JS responsible for that is coming from a CDN and not only that there're multiple references like all the CSS is coming and getting build from the JS files only, on which the logo has been added as HTC component using foreign CSS property introduced by MS as an hack, which is basically a CSS3 Pie Polyfill. The HTC component is also coming from external sources and along with that the actual image which has been referred to the htc component is also coming from an external source.
    So in this case, as we're dependent on multiple external sources, we can't do anything unless all the sources gets updated, we don't have any flexibility to make changes from the codebase. I've also searched for latest CDNs and HTC components from their authorised tool, but no luck in that also.
    Apart from that, the hack was specifically meant to bring better support on IE for images predominantly. In 2024 I think we're not that much concerned for compatibility for IE, in that scenario I think it'll be an overkill and increment of redundant code which in turn might affect the web vitals adversely.

    So basically we need to wait for the maintainer to update the external references. I think it'll be better if we avoid such multiple external references now, as it's reducing the flexibility of the developer to customise the same.

  • Status changed to Needs review 7 months ago
Production build 0.71.5 2024