- Issue created by @Gomez_in_the_South
- ๐ฎ๐ณIndia maithri shetty
Maithri Shetty โ made their first commit to this issueโs fork.
- Merge request !476Issue #3452185: Minimum and maximum feet field made mandatory โ (Open) created by maithri shetty
- last update
6 months ago 536 pass - Status changed to Needs review
6 months ago 6:37am 6 June 2024 - Status changed to RTBC
5 months ago 7:58am 8 July 2024 - ๐ฎ๐ณIndia Nupur Badola
Reviewed the MR, No error is identified as the min and max field are mandatory fields now. Hence marking it to RTBC.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
The below element replicates the issue when the feet are set and not the inches.
height: '#type': webform_height '#title': height '#feet__min': '' '#feet__max': ''
- Status changed to Needs work
about 2 months ago 9:14am 30 September 2024 - ๐บ๐ธUnited States jrockowitz Brooklyn, NY
I want to fix the validation issue and not always require a value.
- ๐ฎ๐ณIndia harshitthakore Pune
Attached patch for validation as implemented validation function for element on save.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Thank you for the patch from #8, but I think we can all min/max to be an empty string and deal with the validation issue via \Drupal\Core\Render\Element\Number::validateNumber.
Please review the MR, which changes the custom min/max from an empty string to
NULL
, which works as expected for determining the offset in\Drupal\Core\Render\Element\Number::validateNumber
via$offset = $element['#min'] ?? 0.0;
. - ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Should this bug be addressed in 6.2.x?
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
I don't mind. I was thinking of 6.2.x as security-updates-only since it goes EOL so soon along with Drupal 10.2.