Validation error for height input field

Maithri Shetty → made their first commit to this issue’s fork.

Reviewed the MR, No error is identified as the min and max field are mandatory fields now. Hence marking it to RTBC.

The below element replicates the issue when the feet are set and not the inches.

height:
  '#type': webform_height
  '#title': height
  '#feet__min': ''
  '#feet__max': ''

I want to fix the validation issue and not always require a value.

Attached patch for validation as implemented validation function for element on save.

Thank you for the patch from #8, but I think we can all min/max to be an empty string and deal with the validation issue via \Drupal\Core\Render\Element\Number::validateNumber.

Please review the MR, which changes the custom min/max from an empty string to NULL, which works as expected for determining the offset in \Drupal\Core\Render\Element\Number::validateNumber via $offset = $element['#min'] ?? 0.0;.

Should this bug be addressed in 6.2.x?

I don't mind. I was thinking of 6.2.x as security-updates-only since it goes EOL so soon along with Drupal 10.2.

If the tests pass, let's merge this.

Automatically closed - issue fixed for 2 weeks with no activity.