- Issue created by @mfb
- Merge request !8249Issue #3451611: Fix the format=flowed; delsp=yes encoding of email messages β (Open) created by mfb
- Status changed to Needs review
30 days ago 3:17pm 31 May 2024 - Status changed to Needs work
27 days ago 1:57pm 3 June 2024 - πΊπΈUnited States smustgrave
Can we provide examples in the summary for how this is better?
Thanks
- Status changed to Needs review
27 days ago 2:34pm 3 June 2024 - πΊπΈUnited States mfb San Francisco
@smustgrave I fleshed out part of the steps to reproduce a bit. If we need more, maybe you can clarify what you would like an example of.
- πΊπΈUnited States smustgrave
Vastly improved display of email messages in email clients
can we get screenshots of the improvements
- πΊπΈUnited States mfb San Francisco
Ok I added some screenshots for the default out-of-the-box mailer, with and without the patch applied. (The other bug fixed by this patch is that the body is soft-wrapped but words are stuck together due to missing space; I didn't yet dig into how to reproduce it, but I suspect it could happen with a non-default mailer setup.)
- Status changed to RTBC
26 days ago 2:34pm 4 June 2024 - π³πΏNew Zealand quietone New Zealand
I read the issue summary, comments and the MR. Just about everything here is in order. It would be better if the screenshots were available from the issue summary but there are only 8 comments so far, so they are not hard to find. There are no unanswered questions. The comments in the MR are clear and easy to understand.
Leaving at RTBC
- Status changed to Needs work
13 days ago 7:18pm 17 June 2024 - πΊπΈUnited States xjm
Made a change to the issue summary... originally it sounded like this needed to be postponed on reverting another issue, but the issue was committed in 2013, so what is actually proposed here is to undo the change from that issue and implement a different fix instead. The situation was further confused by the fact that a better fix was proposed for Drupal 7 but not for Drupal 8, violating the backport policy. :)
- πΊπΈUnited States xjm
An important thing to understand for this issue (which I had to re-read the summary to get) is that
MailFormatHelper::htmlToText()
already callsMailFormatHelper::wrapMail()
, so the second call in the PHP mailer was redundant. - πΊπΈUnited States xjm
NW for the above comments/suggestions I posted on the MR, which should get reviewed by @mfb or another previous issue contributor (i.e., credit will not be granted to someone doing a drive-by application of my suggestions). Thanks!
- Status changed to Needs review
2 days ago 3:49am 28 June 2024 - πΊπΈUnited States mfb San Francisco
Thanks @xjm, I further clarified the comments.
- Status changed to RTBC
2 days ago 1:39pm 28 June 2024 - πΊπΈUnited States smustgrave
Feedback appears to be reviewed by @mfb mvoing back to RTBC.