Contrib.social

Automated Drupal 11 compatibility fixes for votingapi

Open on Drupal.org →
Created on 30 May 2024, 8 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

3.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.3 & MySQL 5.7
    last update 8 months ago
    CI error
  • Comment 8 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-185727

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.1
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !14Draft: Automated Project Update Bot fixes → (Open) created by project update bot
  • Status changed to Closed: won't fix 5 months ago
  • Comment 5 months ago →
    🇺🇸United States tr Cascadia
  • First commit to issue fork.
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇺🇸United States ao5357

    It looks like the rector patch only added ^11 to the info yaml file. It's unclear if other Drupal 11 compatibility fixes are required against 3.x, but it's certainly worthwhile to support Drupal 11. I've manually applied the patch to the MR for ease of composer-ing.

  • Merge request !28Issue #3451390 by ao5357: Manually apply rector patch to info file. → (Open) created by ao5357
  • Pipeline finished with Success
    4 months ago
    Total: 161s
    #275716
  • Status changed to Closed: won't fix 4 months ago
  • Comment 4 months ago →
    🇺🇸United States tr Cascadia
  • Status changed to Needs review 4 months ago
  • Comment 4 months ago →
    🇺🇸United States ao5357

    tr can you either link to the other issue where votingapi will be updated to be compatible with the current version of Drupal or explain why this module won't be updated?

  • Comment 4 months ago →
    🇺🇸United States tr Cascadia

    It already is compatible and working in D11 on the 4.0.x branch. Please leave this issue closed.

  • Status changed to Closed: won't fix 4 months ago
  • Comment 4 months ago →
    🇺🇸United States tr Cascadia
  • Comment 2 months ago →
    ivnish Kazakhstan

    Hi @TR !

    Is there a plan to 4.0 alpha or beta?

  • Comment 2 months ago →
    🇺🇸United States tr Cascadia

    Yes, I am working on votingapi, and fivestar and votingapi_widgets (which depend on votingapi), to get a stable release for all. The big blocker is the structure of the Vote and VoteResult entities need to be changed, and that involves a potentially disruptive hook_update and update tests. These are changes that can only be made in a new major release, which is why I opened the 4.0.x branch, and why I don't want to have a 4.0.0 release without finishing those changes.

  • Comment 2 months ago →
    ivnish Kazakhstan

    This may take a long time. What should people do who need to upgrade to Drupal 11 now? Use the dev version?

  • Comment about 2 months ago →
    🇺🇸United States tr Cascadia

    All I can promise is that I am running 4.0.x-dev on a D11 site and I haven't had problems with it. The best way to find problems is to actually use it - there are probably no more than a handful of sites that have tried it so far. I am making progress, but like you said it's probably going to take a while especially with no community contribution.

  • Comment about 2 months ago →
    ivnish Kazakhstan

    I can help with contribute, but we need a plan for 4.0 release

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024