Add ViewsConfigUpdater deprecation support for default_argument_skip_url

Created on 30 May 2024, 3 months ago
Updated 29 June 2024, 2 months ago

Problem/Motivation

πŸ“Œ Skip default argument for view URL does not work and never has so it can be removed Fixed was committed without deprecation support, this means that approximated 1,500 contrib views don't trigger deprecation notices when modules are installed.

We could add deprecation support now to 10.3.x (and 10.4.x), and then modules with deprecation testing on would be warned before they declare 11.x compatibility, as long as they have test coverage.

See [#/3443942] for the general problem. And see πŸ› Fix label token replacement for views entity reference arguments RTBC for an issue that handles things correctly.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Needs work

Version

10.4 ✨

Component
ViewsΒ  β†’

Last updated about 11 hours ago

Created by

πŸ‡¬πŸ‡§United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @catch
  • First commit to issue fork.
  • Status changed to Needs review 2 months ago
  • πŸ‡³πŸ‡±Netherlands Lendude Amsterdam

    Something like this I guess

  • Pipeline finished with Failed
    2 months ago
    Total: 286s
    #209723
  • Pipeline finished with Failed
    2 months ago
    Total: 377s
    #209722
  • Pipeline finished with Failed
    2 months ago
    Total: 185s
    #209746
  • Pipeline finished with Failed
    2 months ago
    Total: 548s
    #209762
  • Status changed to Needs work 2 months ago
  • πŸ‡³πŸ‡±Netherlands Lendude Amsterdam

    As the test failures indicate, we missed removing some, or some new instances of Views with default_argument_skip_url got added after wards

  • Pipeline finished with Failed
    2 months ago
    Total: 546s
    #210073
  • πŸ‡³πŸ‡±Netherlands Lendude Amsterdam

    I think the remaining failures mean the database fixtures need to be updated? I think?

  • πŸ‡¬πŸ‡§United Kingdom catch

    The update should disable deprecation triggering probably - since we know that views that we update will need the change to be made.

Production build 0.71.5 2024