Close the popup when clicking outside

Created on 29 May 2024, 7 months ago
Updated 6 June 2024, 7 months ago

Problem/Motivation

The popup should close when a user clicks outside

šŸ“Œ Task
Status

RTBC

Version

2.0

Component

Code

Created by

šŸ‡ŗšŸ‡¦Ukraine o_timoshchuk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @o_timoshchuk
  • Issue was unassigned.
  • Status changed to Needs review 7 months ago
  • Open in Jenkins ā†’ Open on Drupal.org ā†’
    Core: 10.2.1 + Environment: PHP 8.2 & MySQL 8
    last update 7 months ago
    1 pass
  • šŸ‡ŗšŸ‡¦Ukraine o_timoshchuk

    The event listener was added to close the popup on clicking outside

  • šŸ‡®šŸ‡³India dev16.addweb

    Patch works fine for me.

  • Status changed to RTBC 7 months ago
  • Hi @everyone,

    Applied the first patch from comment #2, applied it successfully and confirmed the pop up will close when clicking outside. Kindly see the attached files.
    Patch applied successfully:

    external_link_popup git:(2.x) curl https://www.drupal.org/files/issues/2024-05-29/external-link-popup-close-popup-on-click-outside-3450558-1.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100   550  100   550    0     0   1242      0 --:--:-- --:--:-- --:--:--  1300
    patching file js/dialog.js
    āžœ  external_link_popup git:(2.x) āœ—

    Will now move this to RTBC

    Thanks,
    Jake

Production build 0.71.5 2024