Move to new test path in NodeTest as per todo.

Ill pick this one up

Hi, i think the Remaining tasks needs to be revised. I've removed the old test and uncommented the new one. The test can be viewed here with a failure.

If you look at the arguments for assertResourceErrorResponse you see that your arguments to not correcpond with the right ones. The $response variable is in the wrong position. Check out the function arguments, and you should be able to fix that pretty easily by adding a NULL as the $via_link argument. :)

Hi @bbrala,

I'm unable to get the test to pass. I'm getting the following fail message with $url:

PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.27
Configuration: ./core/phpunit.xml.dist

Testing Drupal\Tests\jsonapi\Functional\NodeTest
.F..........                                                      12 / 12 (100%)

Time: 01:16.183, Memory: 6.00 MB

There was 1 failure:

1) Drupal\Tests\jsonapi\Functional\NodeTest::testGetIndividual
The 'errors' member was not as expected.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
         1 => 'Forbidden'
         2 => 'The current user is not allow...ource.'
         3 => Array (
-            0 => Array (...)
-            1 => Array (...)
+            0 => '/data'
         )
+        4 => Array (...)
     )
 )

Or the following error message with NULL:

PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.1.27
Configuration: ./core/phpunit.xml.dist

Testing Drupal\Tests\jsonapi\Functional\NodeTest
.F..........                                                      12 / 12 (100%)

Time: 01:17.307, Memory: 6.00 MB

There was 1 failure:

1) Drupal\Tests\jsonapi\Functional\NodeTest::testGetIndividual
The 'errors' member was not as expected.
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
         1 => 'Forbidden'
         2 => 'The current user is not allow...ource.'
         3 => Array (
-            0 => Array (...)
+            0 => '/data'
         )
+        4 => Array (...)
     )
 )

As im unsure what to do, ill leave this for someone else and check up once complete to learn from the solution.

MR has been updated, fixed PHPUnit tests errors. Needs review.

Seems straightforward

Just fyi @manish-31 this was tagged for novice/new users. Looking at your post history of multiple pages believe are good to work on non-novice level issues.

Committed and pushed 6f6fabe2e6b to 11.x and a83ff827fd4 to 11.0.x and bccb004ae24 to 10.4.x and 389f46becaa to 10.3.x. Thanks!

longwave → closed merge request !8189

Automatically closed - issue fixed for 2 weeks with no activity.